Skip to content

Commit c320a0f

Browse files
committed
addres review comments
1 parent bb27424 commit c320a0f

13 files changed

Lines changed: 854 additions & 449 deletions

‎handwritten/spanner/observability-test/database.ts‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -204,6 +204,7 @@ describe('Database', () => {
204204

205205
const SPANNER = {
206206
routeToLeaderEnabled: true,
207+
_initMetricsTracer: util.noop,
207208
} as {} as Spanner;
208209

209210
const INSTANCE = {
@@ -1282,8 +1283,8 @@ describe('Database', () => {
12821283
done();
12831284
});
12841285

1285-
fakeDataStream.emit('data', 'response');
1286-
fakeDataStream.end('end');
1286+
fakeDataStream.emit('data', {indexes: [0, 1]});
1287+
fakeDataStream.end();
12871288
});
12881289

12891290
it('ends span and does not start RPC when stream is destroyed before getSession resolves', done => {

0 commit comments

Comments
 (0)