Skip to content

Commit c82df08

Browse files
authored
fix(ci): derive requested teams from CODEOWNERS and detect existing PR assignees in assign-reviewers (#9703)
Fixes reviewer auto-assignment in `.github/workflows/assign-reviewers.yml` without requiring organization team token permissions: ### Fixes ### - Add `@quirogas` to `# team_members:`. - Parse file-to-team rules directly from `.github/CODEOWNERS` instead of `pulls.listRequestedReviewers` (which returns `teams: []` under `GITHUB_TOKEN` and previously caused `hasDefaultTeam` to evaluate to `false`, skipping removal of `cloud-sdk-nodejs-team`). - Check human `requested_reviewers`, `assignees`, and `reviews` (`hasHumanReviewerOrAssignee`), and trigger on `review_requested` and `assigned` events so `cloud-sdk-nodejs-team` is reliably removed whenever another reviewer is assigned.
1 parent 60893a7 commit c82df08

2 files changed

Lines changed: 227 additions & 185 deletions

File tree

‎.github/CODEOWNERS‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77

88
# The cloud sdk nodejs team is the default owner for nodejs repositories.
9-
# team_members: @bshaffer @feywind @danieljbruce @shivanee-p
9+
# team_members: @bshaffer @feywind @danieljbruce @shivanee-p @quirogas
1010
* @googleapis/cloud-sdk-nodejs-team
1111

1212
# Generated GAPIC packages, core libraries, and documentation are strictly owned by the Node.js SDK team

0 commit comments

Comments
 (0)