Repository navigation
chore(storage): add storage benchmark tool for Gaxios refactor comparison - #8341
Closed
thiyaguk09 wants to merge 20 commits into
Closed
thiyaguk09 wants to merge 20 commits into
thiyaguk09 wants to merge 20 commits into
Conversation
product-auto-label
Bot
added
the
api: storage
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new benchmarking tool in handwritten/storage/internal-tooling/benchmark.ts along with updated documentation in the README. The tool enables comparative latency and memory benchmarking between the current codebase and a specified baseline NPM version of @google-cloud/storage. Feedback focuses on improving the robustness of dynamic imports for module compatibility, replacing hardcoded values with constants, enhancing type safety by avoiding any[], and refining the throughput calculation logic.
thiyaguk09
marked this pull request as ready for review
May 21, 2026 08:26
Dhriti07
reviewed
May 25, 2026
Dhriti07
reviewed
May 25, 2026
Dhriti07
reviewed
May 25, 2026
Dhriti07
reviewed
May 25, 2026
thiyaguk09
force-pushed
the
storage-node-18
branch
from
May 25, 2026 08:43
eacb087 to
0c58a9a
Compare
thiyaguk09
force-pushed
the
storage-node-18
branch
4 times, most recently
from
June 2, 2026 13:04
e3288e3 to
1fba172
Compare
thiyaguk09
force-pushed
the
storage-node-18
branch
3 times, most recently
from
June 5, 2026 14:22
c0a6220 to
0f2652b
Compare
thiyaguk09
force-pushed
the
storage-node-18
branch
5 times, most recently
from
June 19, 2026 08:19
2c0e9c8 to
696a337
Compare
thiyaguk09
force-pushed
the
storage-node-18
branch
from
June 22, 2026 12:29
696a337 to
fe055f7
Compare
shivanee-p
requested review from
a team
and removed request for
a team,
Dhriti07 and
kalragauri
June 22, 2026 21:15
thiyaguk09
force-pushed
the
storage-node-18
branch
from
June 23, 2026 06:32
ff2fd51 to
d4ee55c
Compare
thiyaguk09
force-pushed
the
storage-gaxios-migration
branch
5 times, most recently
from
September 4, 2026 07:18
3eb2445 to
d749fc2
Compare
thiyaguk09
force-pushed
the
storage-gaxios-migration
branch
5 times, most recently
from
September 9, 2026 01:29
8b3e2ad to
35de221
Compare
…ison refactor: clean up benchmark utility with improved formatting and added imports feat: add support for selective scenario execution in storage benchmarks refactor: remove unnecessary line breaks in list files benchmark call
…nd fix storage tests/lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕