Skip to content

test(bigtable): fix flaky backup system tests #9717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danieljbruce wants to merge 7 commits into from
Closed

test(bigtable): fix flaky backup system tests #9717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
08362cf
test(bigtable): fix flaky backup system tests
danieljbruce Oct 23, 2026
d57cbd1
[Style Maintenance] align changes with CONTRIBUTING.md and gts coding…
danieljbruce Oct 23, 2026
c6ddbd2
[Independent review follow-ups] address independent Gemini review com…
danieljbruce Oct 23, 2026
1cf29f8
[Independent review follow-ups] address independent Gemini review com…
danieljbruce Oct 23, 2026
c058424
[Address CI errors] check restored table existence on DIFF_INSTANCE i…
danieljbruce Oct 26, 2026
04d2692
[Address CI errors] fix circular require in mutateInternal and client…
danieljbruce Oct 26, 2026
fd56037
[Address CI errors] restore waitForReplication fake timer spies via s…
danieljbruce Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions handwritten/bigtable/src/client-side-metrics/exporter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,13 @@ function getInterval(
const startSec = dataPoint.startTime[0];
const startNanos = dataPoint.startTime[1];

if (startSec > endSec || (startSec === endSec && startNanos > endNanos)) {
if (startSec > endSec || (startSec === endSec && startNanos >= endNanos)) {
endSec = startSec;
endNanos = startNanos;
endNanos = startNanos + 1_000_000;
if (endNanos >= 1_000_000_000) {
endSec += 1;
endNanos -= 1_000_000_000;
}

@danieljbruce danieljbruce Oct 26, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modifying the timestamps for our metrics does not seem like something we should do.

@danieljbruce danieljbruce Oct 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at this again, I can see we already made changes in danieljbruce@1ea27c9 to artificially change the end and start nanos and it seems the problem with that change is that it is setting the endNanos to the startNanos which is still causing errors. In other words, setting endNanos to startNanos didn't really solve the flakey tests.

@danieljbruce danieljbruce Oct 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

danieljbruce@1ea27c9#diff-39c2f3c691ce7c9e2f54ab8c9020dff4aef632d80a11aa13fe19074c889aaad5R54-R56 is the link to the exact changes from the other commit.

@danieljbruce danieljbruce Oct 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is possible, we should really try to revert the change from the previous PR and fix the tests only with test changes if possible.

}

return {
Expand Down
9 changes: 3 additions & 6 deletions handwritten/bigtable/src/utils/mutateInternal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,13 @@
// See the License for the specific language governing permissions and
// limitations under the License.

import {
Entry,
MutateCallback,
MutateOptions,
PartialFailureError,
} from '../table';
import {Entry, MutateOptions} from '../table';
import {OperationMetricsCollector} from '../client-side-metrics/operation-metrics-collector';
import {
DEFAULT_BACKOFF_SETTINGS,
getNextDelay,
MutateCallback,
PartialFailureError,
populateAttemptHeader,
RETRYABLE_STATUS_CODES,
TabularApiSurface,
Expand Down Expand Up @@ -189,7 +186,7 @@
// Handling retries in this client. Specify the retry options to
// make sure nothing is retried in retry-request.
noResponseRetries: 0,
shouldRetryFn: (_: any) => {

Check warning on line 189 in handwritten/bigtable/src/utils/mutateInternal.ts

View workflow job for this annotation

GitHub Actions / lint 

Unexpected any. Specify a different type

Check warning on line 189 in handwritten/bigtable/src/utils/mutateInternal.ts

View workflow job for this annotation

GitHub Actions / lint 

'_' is defined but never used
return false;
},
};
Expand Down
Loading
Loading