[shivanee-p]

This pull request integrates logNetworkAttempt and logCall into createApiCall.

Key Changes:

• Checked checkLoggingEnabled(settings) in createApiCall and initialized staticArgs, dynamicArgs, and attemptDynamicArgs when either tracing or logging is enabled.
• Wrapped each transport network attempt in createApiCall with logNetworkAttempt when telemetry logging is enabled, nested inside traceAttempt when tracing is also enabled so attempt logs capture the active T4 attempt span context.
• Wrapped each logical client request in createApiCall with logCall (passing attemptDynamicArgs so rpc.method includes the RPC service and method name) when telemetry logging is enabled, nested inside traceCall when tracing is also enabled so terminal error logs capture the active T3 client request span context.

[gemini-code-assist]

Code Review

This pull request integrates telemetry logging capabilities into createApiCall by conditionally wrapping API calls and network attempts with logging functions, supported by a comprehensive suite of new unit tests. The feedback advises against weakening test coverage in loggerHelper.ts where assertions for the absence of exception fields were removed, suggesting instead to assert that these fields are undefined.

I am having trouble creating individual review comments. Click here to see my feedback.

core/packages/gax/test/unit/loggerHelper.ts (580-582)

Removing these assertions weakens the test coverage for verifying that exception fields are not present in successful logs. If these assertions were removed because the keys might be present with undefined values (e.g., due to changes in the logging backend), we should instead assert that their values are undefined. This maintains robust test coverage without being fragile to the physical presence of the keys in the object.

      assert.strictEqual(otherWithoutMeta['exception.type'], undefined);
      assert.strictEqual(otherWithoutMeta['exception.message'], undefined);
      assert.strictEqual(otherWithoutMeta['exception.stacktrace'], undefined);

References

1. Do not weaken test assertions (e.g., changing a specific minimum count assertion to a simple greater-than-zero check) solely to avoid fragility, as this reduces test coverage.

[quirogas]

LGTM! Approving to unblock—left a few minor non-blocking nits inline.

[quirogas]

Nit: This PR deletes 3 assertions in test/unit/loggerHelper.ts (exception.type, exception.message, exception.stacktrace absence on otherWithoutMeta) that were added in #9757. Drop this unrelated hunk so #9760 stays scoped to createApiCall.ts and test/unit/apiCallable.ts.