Repository navigation
chore(deps): remove unused proxyquire devDependencies - #9784
danieljbruce merged 6 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the proxyquire and @types/proxyquire dependencies from multiple packages, including core/common, handwritten/bigquery, handwritten/datastore, and handwritten/google-cloud-dns, and updates the pnpm-lock.yaml lockfile accordingly. I have no feedback to provide as the changes are clean and there are no review comments to address.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request removes the proxyquire and @types/proxyquire dependencies across several packages, specifically core/common, handwritten/bigquery, handwritten/datastore, and handwritten/google-cloud-dns, as well as updating the pnpm-lock.yaml lockfile. There are no review comments, and the changes are straightforward, so I have no feedback to provide.
…-proxyquire-devdeps
…-proxyquire-devdeps
|
/gemini review |
danieljbruce
changed the title
…-proxyquire-devdeps # Conflicts: # handwritten/storage/package.json # pnpm-lock.yaml
Description
Removes the remaining unused
"@types/proxyquire"and"proxyquire"devDependenciesacross the repository (plus the correspondingpnpm-lock.yamlentries) following the migration of unit tests fromproxyquiretosinonandgoogle-test-utilsacross#9642–#9646, as noted in #9643 (comment) (b/579954082).Packages Updated
core/common/package.json(#9643)core/packages/gax/package.json(#9645)core/packages/nodejs-googleapis-common/package.json(#9645)core/packages/nodejs-proto-files/package.jsonhandwritten/bigquery/package.json(#9643)handwritten/bigtable/package.json(#9642)handwritten/datastore/package.json(#9643)handwritten/error-reporting/package.json(#9642)handwritten/firestore/package.jsonhandwritten/google-cloud-dns/package.json(#9643)handwritten/logging/package.json(#9642)handwritten/logging-bunyan/package.json(#9642)handwritten/logging-winston/package.json(#9642)handwritten/pubsub/package.json(#9642)handwritten/spanner/package.json(#9644)handwritten/storage/package.json(#9645)packages/google-cloud-compute/samples/package.jsonpackages/google-cloud-translate/package.json(#9645)pnpm-lock.yamlTesting
pnpm --dir <pkg> run compile) across all modified packages.JS_RUNTIME=bun) across all modified packages with 0 failures (>= 95%confidence).git grep "proxyquire" -- "**/package.json" package.jsonreturns 0 remaining matches across the monorepo.node ./bin/linter.mjs --strictandcionlycommit/style audits pass cleanly.