Repository navigation
feat(gax): add logging to observability sample - #9786
Open
shivanee-p wants to merge 1 commit into
Open
shivanee-p wants to merge 1 commit into
shivanee-p wants to merge 1 commit into
Conversation
product-auto-label
Bot
added
the
samples
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces telemetry logging capabilities across Google Cloud Node.js client libraries, integrating it with OpenTelemetry tracing, and refactoring the core GAX client options, error utilities, and settings construction. The review feedback highlights several critical issues: constructSettings is called with arguments in the incorrect order in iamService.ts, locationService.ts, and operationsClient.ts. Additionally, potential runtime TypeError crashes were identified in gax.ts when backoff or retry is null/undefined, and in LoggerHelper.ts if loggingUtils.getNodeBackend() returns null or undefined.
shivanee-p
force-pushed
the
shivaneep-release-logging
branch
from
October 30, 2026 22:26
28f3e69 to
25f823b
Compare
shivanee-p
force-pushed
the
shivaneep-release-logging
branch
from
October 30, 2026 23:35
25f823b to
7cc3010
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add logging implementation to the observability sample and remove the logging experimental flag check