Skip to content

ci(bigquery): compile and test Discovery types before PR sync - #9910

Open
quirogas wants to merge 1 commit into
googleapis:mainfrom
quirogas:ci/discovery-compile-and-frozen-lockfile
Open

quirogas wants to merge 1 commit into
googleapis:mainfrom
quirogas:ci/discovery-compile-and-frozen-lockfile

Conversation

@quirogas

Copy link
Copy Markdown
Contributor

Description

Compiles and tests generated BigQuery Discovery types before opening PRs.

Impact

Catches broken Discovery type updates inside the scheduled workflow.

Changes

  • Install @google-cloud/bigquery dependencies from the root workspace using --frozen-lockfile --ignore-scripts.
  • Scope formatting strictly to src/types.d.ts and run compile and test before code-suggester creates a pull request.
  • Add concurrency and timeout-minutes: 15, upgrade actions/checkout and actions/setup-node to pinned v6 SHAs, and include @googleapis/bigquery-team in failure notifications.

Testing

  • Validated .github/workflows/discovery.yaml YAML syntax and verified @google-cloud/bigquery script definitions in handwritten/bigquery/package.json.

Alternatives

  • Opening Discovery type PRs without compiling or testing inside the cron job shifts failure detection onto downstream pull request checks.

@product-auto-label product-auto-label Bot added the api: bigquery Issues related to the BigQuery API. label Nov 19, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@quirogas
quirogas marked this pull request as ready for review November 19, 2026 21:16
@quirogas
quirogas requested review from a team as code owners November 19, 2026 21:16

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the BigQuery API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant