diff --git a/core/packages/tools/bin/minifyProtoJson.js b/core/packages/tools/bin/minifyProtoJson.js index 4384420bc702..9bdd9333f74e 100755 --- a/core/packages/tools/bin/minifyProtoJson.js +++ b/core/packages/tools/bin/minifyProtoJson.js @@ -19,4 +19,7 @@ if (process.argv[2] === '--help') { console.log(`Usage: node ${process.argv[1]} [directory]`); process.exit(1); } -main(process.argv[2]); +main(process.argv[2]).catch(err => { + console.error(err); + process.exitCode = 1; +}); diff --git a/core/packages/tools/src/minify.ts b/core/packages/tools/src/minify.ts index 08c71f51c8b6..33883e9e682d 100644 --- a/core/packages/tools/src/minify.ts +++ b/core/packages/tools/src/minify.ts @@ -76,6 +76,8 @@ if (require.main === module) { process.exit(1); } - // eslint-disable-next-line @typescript-eslint/no-floating-promises - main(process.argv[2]); + main(process.argv[2]).catch(err => { + console.error(err); + process.exitCode = 1; + }); } diff --git a/core/packages/tools/test/minify.ts b/core/packages/tools/test/minify.ts index 62203ac74b2f..6855116b7c90 100644 --- a/core/packages/tools/test/minify.ts +++ b/core/packages/tools/test/minify.ts @@ -13,6 +13,7 @@ // limitations under the License. import * as assert from 'assert'; +import {spawnSync} from 'child_process'; import {describe, it, beforeEach} from 'mocha'; import * as fs from 'fs'; import {promises as fsp} from 'fs'; @@ -60,4 +61,19 @@ describe('minify tool', () => { assert(statBefore.size > statAfter.size); assert.deepEqual(resultBefore, resultAfter); }); + + it('exits non-zero when CLI execution fails', () => { + const cliPath = path.join( + __dirname, + '..', + '..', + 'bin', + 'minifyProtoJson.js', + ); + const missingDir = path.join(testDir, 'missing-dir'); + const result = spawnSync(process.execPath, [cliPath, missingDir], { + encoding: 'utf8', + }); + assert.strictEqual(result.status, 1); + }); });