Skip to content

chore(core): remove legacy CI configs and empty test stubs - #9916

Draft
quirogas wants to merge 1 commit into
googleapis:mainfrom
quirogas:chore/core-delete-legacy-ci-and-stubs
Draft

quirogas wants to merge 1 commit into
googleapis:mainfrom
quirogas:chore/core-delete-legacy-ci-and-stubs

Conversation

@quirogas

Copy link
Copy Markdown
Contributor

Description

Deletes retired Kokoro, CircleCI, baseline duplicates, and empty system-test stubs.

Impact

Removes unreferenced split-repo CI files across core utility packages.

Changes

  • Delete unreferenced .kokoro/, .trampolinerc, and .circleci/config.yml files across core/common, core/paginator, core/precise-date, core/projectify, core/promisify, core/packages/gax, and core/packages/retry-request.
  • Delete duplicate orphaned core/generator/gapic-generator-typescript/baselines-esm/duplicate_methods_test-esm/ fixtures (unit tests read exclusively from baselines/).
  • Remove zero-assertion system-test/system.ts stubs and broken samples/ scripts from core/precise-date, core/promisify, and core/common.

Testing

  • Verified no GitHub Actions workflows or monorepo scripts reference deleted .kokoro/, .trampolinerc, .circleci/, or baselines-esm/ files.
  • Verified unit tests pass in core/precise-date, core/promisify, and core/common.

Alternatives

  • Retaining retired split-repo CI configurations and empty test stubs adds maintenance noise across core/.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes Kokoro CI configurations, CircleCI configurations, system tests, and sample tests across multiple sub-packages, including core/common, core/paginator, core/precise-date, core/projectify, and core/promisify. The test scripts in package.json files have been replaced with placeholder echo statements, and corresponding tsconfig.json files have been updated to exclude system test directories. I have no feedback to provide as there are no review comments.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant