Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes several obsolete utility and migration scripts, including those for git history migration, issue transferring, repository deprecation, and post-processing. Additionally, it removes the postpublish script hook from handwritten/logging/package.json which previously executed the deleted minified publishing script. I have no feedback to provide as these changes successfully clean up unused scripts.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes unused split-repo migration scripts and the retired
postpublishhook.Impact
Cleans up obsolete pre-monorepo scripts that no longer run in releases.
Changes
bin/(delete-everything-split-repo.sh,migrate-git-history.sh,migrate-split-repo.sh,migrate-split-tag.sh,split-repo-post-process.sh,transfer-issues.sh,update-readme-only-split-repo.sh).handwritten/logging/.kokoro/publish-min.shand remove the unused"postpublish"entry fromhandwritten/logging/package.json(pnpm packrelease builds do not invokepostpublish).Testing
bin/*migration scripts orpublish-min.shacross repository workflows and packages.handwritten/logging/package.jsonJSON syntax.Alternatives
postpublishhooks in the repository suggests they are still part of active workflows.