Skip to content

ci: clean up legacy CI configs and scripts in C08 database packages - #9918

Draft
danieljbruce wants to merge 1 commit into
googleapis:mainfrom
danieljbruce:chore/c08-database-legacy-ci-cleanup
Draft

danieljbruce wants to merge 1 commit into
googleapis:mainfrom
danieljbruce:chore/c08-database-legacy-ci-cleanup

Conversation

@danieljbruce

Copy link
Copy Markdown
Contributor

Description

Cleans up legacy CI configs and scripts across C08 packages.

Impact

Removes dead Kokoro configs, unused Cloud Build steps, and broken scripts.

Changes

  • Relocate handwritten/bigtable/.kokoro/mandatory-conformance.sh to handwritten/bigtable/scripts/mandatory-conformance.sh (with executable permissions) and update .github/workflows/mandatory-conformance.yaml to invoke ./scripts/mandatory-conformance.sh.
  • Delete 109 dead .kokoro/ and .trampolinerc files across handwritten/bigtable (27), handwritten/datastore (27), handwritten/firestore (26), and handwritten/spanner (29); handwritten/spanner-driver already contained none.
  • Intentionally leave handwritten/bigtable/.kokoro/conformance.sh and handwritten/bigtable/.kokoro/coerce_logs.sh untouched because .github/workflows/bigtable-conformance.yaml still references them on main; they are removed together with bigtable-conformance.yaml in a separate PR so this PR does not break bigtable-conformance.yaml regardless of merge order.
  • Remove the unused nyc coverage-report step from cloudbuild.yaml in handwritten/spanner, handwritten/firestore, handwritten/bigtable, and handwritten/datastore (handwritten/spanner-driver/cloudbuild.yaml and cloudbuild_pg_test_suite.yaml already omit it).
  • Remove broken prelint, samples-test, and snippet-test scripts from handwritten/bigtable/package.json and broken prelint and samples-test scripts from handwritten/datastore/package.json (spanner, spanner-driver, and firestore do not have these scripts).

Testing

  • Validated YAML syntax of .github/workflows/mandatory-conformance.yaml and all four updated cloudbuild.yaml files with PyYAML, JSON syntax of both modified package.json files, and shell syntax of handwritten/bigtable/scripts/mandatory-conformance.sh with bash -n.
  • Verified via git grep that no workflow, package.json, or repository hook references any deleted .kokoro/ or .trampolinerc file (aside from the intentionally preserved handwritten/bigtable/.kokoro/conformance.sh and coerce_logs.sh).
  • Compiled all four modified packages (bigtable, datastore, firestore, spanner) with pnpm run compile and verified GIT_DIFF_ARG="upstream/main...HEAD -- :!packages" node ./bin/linter.mjs --strict passes.
  • Ran unit tests on Node.js and Bun for handwritten/datastore (823 passing on both) and handwritten/firestore (unit + 228 conformance tests passing on both); bigtable and spanner unit tests plus mandatory-conformance are validated in GitHub Actions CI.
  • Verified pnpm --dir handwritten/datastore run lint executes gts check directly without failing on the removed prelint script.

Alternatives

  • Leaving retired split-repo Kokoro configs, no-op Cloud Build nyc steps, and broken samples scripts in place adds maintenance noise, wastes Cloud Build container startups, and breaks local pnpm run lint invocations in bigtable and datastore.
  • Deleting handwritten/bigtable/.kokoro/conformance.sh and coerce_logs.sh in this PR was rejected because .github/workflows/bigtable-conformance.yaml still calls them on main; preserving them lets both PRs merge cleanly in either order.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes legacy Kokoro CI configuration files, trampoline scripts, and related shell scripts across multiple handwritten packages, including bigtable, datastore, firestore, and spanner. Additionally, it removes the optional code coverage reporting steps from the respective cloudbuild.yaml files and cleans up unused scripts from package.json files. I have no feedback to provide as there are no review comments.

@danieljbruce

Copy link
Copy Markdown
Contributor Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request cleans up legacy Kokoro CI/CD configurations, scripts, and related tooling across multiple handwritten Node.js Google Cloud client libraries, including Bigtable, Datastore, Firestore, and Spanner. Specifically, it removes .kokoro directories, trampoline scripts, and unused npm scripts (such as prelint and samples-test). Additionally, it removes the optional code coverage reporting step from the cloudbuild.yaml files in these packages. I have no feedback to provide as there are no review comments to address.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant