Repository navigation
ci: clean up legacy CI configs and scripts in C08 database packages - #9918
danieljbruce wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request removes legacy Kokoro CI configuration files, trampoline scripts, and related shell scripts across multiple handwritten packages, including bigtable, datastore, firestore, and spanner. Additionally, it removes the optional code coverage reporting steps from the respective cloudbuild.yaml files and cleans up unused scripts from package.json files. I have no feedback to provide as there are no review comments.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request cleans up legacy Kokoro CI/CD configurations, scripts, and related tooling across multiple handwritten Node.js Google Cloud client libraries, including Bigtable, Datastore, Firestore, and Spanner. Specifically, it removes .kokoro directories, trampoline scripts, and unused npm scripts (such as prelint and samples-test). Additionally, it removes the optional code coverage reporting step from the cloudbuild.yaml files in these packages. I have no feedback to provide as there are no review comments to address.
Description
Cleans up legacy CI configs and scripts across C08 packages.
Impact
Removes dead Kokoro configs, unused Cloud Build steps, and broken scripts.
Changes
handwritten/bigtable/.kokoro/mandatory-conformance.shtohandwritten/bigtable/scripts/mandatory-conformance.sh(with executable permissions) and update.github/workflows/mandatory-conformance.yamlto invoke./scripts/mandatory-conformance.sh..kokoro/and.trampolinercfiles acrosshandwritten/bigtable(27),handwritten/datastore(27),handwritten/firestore(26), andhandwritten/spanner(29);handwritten/spanner-driveralready contained none.handwritten/bigtable/.kokoro/conformance.shandhandwritten/bigtable/.kokoro/coerce_logs.shuntouched because.github/workflows/bigtable-conformance.yamlstill references them onmain; they are removed together withbigtable-conformance.yamlin a separate PR so this PR does not breakbigtable-conformance.yamlregardless of merge order.nyccoverage-reportstep fromcloudbuild.yamlinhandwritten/spanner,handwritten/firestore,handwritten/bigtable, andhandwritten/datastore(handwritten/spanner-driver/cloudbuild.yamlandcloudbuild_pg_test_suite.yamlalready omit it).prelint,samples-test, andsnippet-testscripts fromhandwritten/bigtable/package.jsonand brokenprelintandsamples-testscripts fromhandwritten/datastore/package.json(spanner,spanner-driver, andfirestoredo not have these scripts).Testing
.github/workflows/mandatory-conformance.yamland all four updatedcloudbuild.yamlfiles with PyYAML, JSON syntax of both modifiedpackage.jsonfiles, and shell syntax ofhandwritten/bigtable/scripts/mandatory-conformance.shwithbash -n.git grepthat no workflow,package.json, or repository hook references any deleted.kokoro/or.trampolinercfile (aside from the intentionally preservedhandwritten/bigtable/.kokoro/conformance.shandcoerce_logs.sh).bigtable,datastore,firestore,spanner) withpnpm run compileand verifiedGIT_DIFF_ARG="upstream/main...HEAD -- :!packages" node ./bin/linter.mjs --strictpasses.handwritten/datastore(823 passing on both) andhandwritten/firestore(unit + 228 conformance tests passing on both);bigtableandspannerunit tests plusmandatory-conformanceare validated in GitHub Actions CI.pnpm --dir handwritten/datastore run lintexecutesgts checkdirectly without failing on the removedprelintscript.Alternatives
nycsteps, and brokensamplesscripts in place adds maintenance noise, wastes Cloud Build container startups, and breaks localpnpm run lintinvocations inbigtableanddatastore.handwritten/bigtable/.kokoro/conformance.shandcoerce_logs.shin this PR was rejected because.github/workflows/bigtable-conformance.yamlstill calls them onmain; preserving them lets both PRs merge cleanly in either order.