You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 292cfa5
Browse filesBrowse the repository at this point in the historyBrowse files
docs: deprecate the enableSnappy option in bigtable-beam-import (#4635)
The flag has been a no-op since #4338 (released in 2.14.0), which moved the
import job to HBase 2.x / Hadoop 3. Its only effect was swapping in a custom
SDK container image and enabling use_runner_v2 so that workers could
decompress Snappy; that block was deleted in #4338 and nothing has read
getEnableSnappy() since. Snappy compressed snapshots are now read natively.
Mark the option deprecated rather than removing it so existing invocations
keep working:
- @deprecated on the getter/setter, and the --help description now says the
option is ignored.
- Log a warning when --enableSnappy=true is passed so it is not silently
dropped.
- README: collapse the duplicated "Snappy compressed Snapshots" command block
(identical to the preferred method except for the flag) into a note that no
extra configuration is needed, plus a deprecation warning.
- SNAPSHOT_IMPORT_USAGE.md: mark ENABLE_SNAPPY deprecated.
- run-snapshot-import.sh: stop passing --enableSnappy; warn if ENABLE_SNAPPY
is set in the environment.
- EndToEndIT: drop the setEnableSnappy(true) call; the test still imports the
snappy snapshot.
Change-Id: I7113f112309c7813fba7cc0d7c9b73401029d620
Copy file name to clipboardExpand all lines: bigtable-dataflow-parent/bigtable-beam-import/src/main/java/com/google/cloud/bigtable/beam/hbasesnapshots/ImportJobFromHbaseSnapshot.java
+26-1Lines changed: 26 additions & 1 deletion
Original file line number
Diff line number
Diff line change
@@ -120,10 +120,23 @@ public interface ImportOptions extends ImportJob.ImportOptions {
Copy file name to clipboardExpand all lines: bigtable-dataflow-parent/bigtable-beam-import/src/test/java/com/google/cloud/bigtable/beam/hbasesnapshots/EndToEndIT.java
+1-1Lines changed: 1 addition & 1 deletion
Original file line number
Diff line number
Diff line change
@@ -419,8 +419,8 @@ public void testHBaseSnapshotImportWithCorruptions() throws Exception {
0 commit comments