feat(maps-compose): default mapColorScheme to FOLLOW_SYSTEM in GoogleMap - #986
Open
dkhawk wants to merge 1 commit into
Open
feat(maps-compose): default mapColorScheme to FOLLOW_SYSTEM in GoogleMap#986dkhawk wants to merge 1 commit into
dkhawk wants to merge 1 commit into
Conversation
Default `GoogleMap`'s `mapColorScheme` parameter to `ComposeMapColorScheme.FOLLOW_SYSTEM` instead of `null`. Previously, `mapColorScheme` defaulted to `null`, which resulted in `GoogleMapOptions` retaining the unconfigured Java int default of `0` (`MapColorScheme.LIGHT`) and left `map.mapColorScheme` unset in `MapUpdater`. This forced maps created without an explicit `mapColorScheme` parameter into light mode on dark-themed devices. Defaulting to `FOLLOW_SYSTEM` ensures `GoogleMap` automatically adheres to the system theme out of the box, aligning with Compose and Android conventions. Includes regression tests in `GoogleMapViewTests.kt` validating that default `GoogleMap` invocations and factory configurations receive `MapColorScheme.FOLLOW_SYSTEM`.
Contributor
Code Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates
GoogleMap'smapColorSchemeparameter to default toComposeMapColorScheme.FOLLOW_SYSTEMinstead ofnull.Rationale
mapColorSchemedefaulted tonull. AsGoogleMapOptions.getMapColorScheme()returns Java's default0(MapColorScheme.LIGHT) andMapUpdaterskipped settingmap.mapColorSchemewhenmapColorSchemewas null, maps initialized without an explicitmapColorSchemeparameter were silently forced into light mode, even when the host device was in system dark theme.ComposeMapColorScheme.FOLLOW_SYSTEMensuresGoogleMapautomatically adapts to the system theme out of the box, adhering to standard Jetpack Compose and Material 3 design expectations.Verification
testDefaultColorSchemeIsFollowSystemandtestDefaultColorSchemeWithGoogleMapOptionsFactoryinGoogleMapViewTests.kt.GoogleMapViewTestspass on device.