fix(gmail): preserve rich message bodies in read - #897
Conversation
🦋 Changeset detectedLatest commit: 3e25d9b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
This PR has been inactive for 72 hours. Closing to keep the queue clean. |
|
This PR was closed because it has been stalled for 72 hours. Feel free to magically reopen it if you want to continue working on it! |
|
The Google CLA is now signed and the CLA check passes. The branch is still current with main and GitHub reports it mergeable. The normal author reopen operation is returning a validation error after the stale bot closed it; could a maintainer please reopen this PR? I’m ready to address review or CI feedback. |
Description
Fixes #889.
Gmail
+readcurrently falls back to the truncated snippet for HTML-only messages and can prefer a short or emptytext/plainalternative over substantially richer HTML. Naive tag stripping also loses link targets, entity decoding, and block structure.This change:
html2text, retaining links and document structureAll fixtures are synthetic; no Gmail account, credentials, or real messages were used.
Validation
The five initial regressions all failed on pristine
a3768d0:They cover richer multipart selection, non-truncation, anchor
hrefpreservation, HTML entity decoding, and block line breaks. The final suite also covers empty and comparable plain-text alternatives.cargo fmt --all -- --checkcargo test -p google-workspace-cli test_read_— 7 passedcargo test -p google-workspace-cli helpers::gmail::— 242 passedcargo build --workspacecargo clippy --workspace -- -D warningsThe two excluded ADC tests mutate
HOMEwhiledirs::home_dir()readsUSERPROFILEon Windows; they are outside the Gmail helper and unchanged by this commit.