Skip to content

fix(modal): make dismiss idempotent when modal is not presented #2711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
janicduplessis wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(modal): make dismiss idempotent when modal is not presented #2711

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/components/bottomSheetModal/BottomSheetModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,13 +273,15 @@ function BottomSheetModalComponent<T = never>(
}

/**
* if the modal position is already in a closed position,
* if the modal was never presented or is already in a closed position,
* then we unmount the node and early exit.
*/
if (
[MODAL_STATUS.CLOSED, MODAL_STATUS.MINIMIZED].includes(
statusRef.current
) ||
[
MODAL_STATUS.INITIAL,
MODAL_STATUS.CLOSED,
MODAL_STATUS.MINIMIZED,
].includes(statusRef.current) ||
(statusRef.current === MODAL_STATUS.DISMISSING &&
currentIndexRef.current === -1)
) {
Expand Down
Loading