fix: hide closed sheets below edge-to-edge containers - #2754
Open
huytdps13400 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please provide enough information so that others can review your pull request:
Motivation
Fixes #2747.
On Android edge-to-edge devices,
Dimensions.get('window').heightcan exclude system bars while the measured sheet container spans the full screen. A sheet mounted permanently atindex={-1}can therefore start above its real closed detent and leave its handle visible.Initialize the Android position from
screen.height, which stays at or below the full-screen container edge. Keep the existingwindow.heightbehavior on iOS and web so their mount-animation starting point is unchanged.Verification
master: failed while the initial position usedwindow.heightscreen.height, other platforms selectwindow.heightyarn typescriptyarn buildyarn biome check --error-on-warnings src/components/bottomSheet/BottomSheet.tsxgit diff --checkRepository-wide
yarn lintstill reports the existing unrelated optional-chain warning insrc/hooks/useBoundingClientRect.ts:54; the changed file is clean.I could not run the hardware-specific Samsung edge-to-edge reproduction locally. The patch matches the measured
window < container == screengeometry and keeps the non-Android path unchanged.