Bound CloseError.Error text to the control-frame limit - #1028
Open
AshSgDe29071999 wants to merge 1 commit into
Open
Bound CloseError.Error text to the control-frame limit#1028AshSgDe29071999 wants to merge 1 commit into
AshSgDe29071999 wants to merge 1 commit into
Conversation
Error() appended Text without a length cap. A CloseError with a huge Text (corrupt state or a caller-built value) could OOM while formatting the error. Truncate to maxControlFramePayloadSize, the protocol maximum for close-frame payloads. See gorilla#1002
|
If the WebSocket package itself can create a CloseError with len(Text) > 125, then that should be fixed. There’s no reason for an application to construct a CloseError directly. If it does, the application should be responsible for the consequences of setting CloseError.Text to a huge string. If the Gorilla maintainers nevertheless consider the package responsible for protecting applications from this kind of misuse, then the text should be truncated at a valid UTF-8 boundary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1002
CloseError.ErrorappendedTextwith no length cap. A hugeText(corrupt state or a caller-built value) could OOM while formattingerrfor a logger.Truncate to
maxControlFramePayloadSize(125), the WebSocket maximum for close-frame payloads. The connection already enforces that limit when parsing close frames.