Pass the combo payload by reference in its checksum test - #595
Draft
cursor[bot] wants to merge 1 commit into
Draft
Pass the combo payload by reference in its checksum test#595cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
#502 left bare.clone() in checksummed_combo_is_analysed. json! only borrows the String, so clippy::redundant_clone fails -D warnings on bitcoin-rs-rpc test targets. Co-authored-by: metaphorics <metaphorics@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
clippyonmainfailed after #502 with-D clippy::redundant_cloneinchecksummed_combo_is_analysed.json!only borrows the bare combo string, so.clone()is unused and the later checksummed call still needsbare.What changed
Pass
&bareintojson!instead of cloning. Test contract is unchanged: bare and checksummedcombo(KEY)still analyse to the samegetdescriptorinforesult.Verification
cargo clippy -p bitcoin-rs-rpc --all-targets -- -D warningscargo test -p bitcoin-rs-rpc --lib descriptor_checksum_tests::checksummed_combo_is_analysed