fix(utils): accept loopback http relay URLs - #337
Merged
Conversation
Loopback http --portal-url died in NormalizeRelayURL before the localhost development certificate path. Rewrite loopback http to https. Non-loopback http is still rejected. Closes #336
Contributor
|
Warning Review limit reachedNext included review available in 3 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relay-server --portal-url http://127.0.0.1:<api-port>exited withrelay url must use httpsand never reached the localhost development-certificate path.Loopback
http://URLs now rewrite tohttps://inNormalizeRelayURL. Publichttp://relay URLs stay rejected.Tests:
TestNormalizeRelayURLRewritesLoopbackHTTP,TestNormalizeRelayURLRejectsNonLoopbackHTTP.Replay of the original command no longer fails at URL normalize; the next error is the documented missing embedded frontend (
make build-frontend).Closes #336
Post-Deploy Monitoring & Validation
No production relay impact. Confirm a loopback
http://127.0.0.1portal-url starts past URL normalize. If a non-loopbackhttp://relay URL is accepted, revert.