Skip to content

fix(portal): log unknown public SNI hostnames - #343

Merged
gosunuts merged 1 commit into
mainfrom
fix/sni-unknown-host-log
Aug 28, 2026
Merged

fix(portal): log unknown public SNI hostnames#343
gosunuts merged 1 commit into
mainfrom
fix/sni-unknown-host-log

Conversation

@gosunuts

Copy link
Copy Markdown
Member

A loopback expose logged service ready at https://name.localhost:14443 while the relay still had the lease as name.127.0.0.1. openssl s_client to the ready hostname got unexpected eof. The matching registered hostname completed TLS. The relay logged nothing.

Unknown SNI names now emit warn unknown public ingress hostname with server_name and remote_addr. Routing is unchanged.

Closes #342

Post-Deploy Monitoring & Validation

A ClientHello whose SNI is not a registered lease should produce warn unknown public ingress hostname. If that line is missing and clients still see TLS EOF on a ready URL, revert.

Lookup misses on public ingress closed the TCP connection
with no log, so a ready URL that did not match the
registered hostname failed TLS with unexpected eof.

Closes #342
@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 7 minutes.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 19b2a184-e2db-42bf-97dd-dd51ea8b223d

📥 Commits

Reviewing files that changed from the base of the PR and between cfb06ea and 36b8787.

📒 Files selected for processing (1)
  • portal/server.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gosunuts
gosunuts merged commit 5367fa4 into main Aug 28, 2026
7 checks passed
@gosunuts
gosunuts deleted the fix/sni-unknown-host-log branch August 28, 2026 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unknown SNI hostname closes the connection with no log

1 participant