fix(portal): log unknown public SNI hostnames - #343
Merged
Conversation
Lookup misses on public ingress closed the TCP connection with no log, so a ready URL that did not match the registered hostname failed TLS with unexpected eof. Closes #342
Contributor
|
Warning Review limit reachedNext included review available in 7 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A loopback expose logged
service ready at https://name.localhost:14443while the relay still had the lease asname.127.0.0.1.openssl s_clientto the ready hostname gotunexpected eof. The matching registered hostname completed TLS. The relay logged nothing.Unknown SNI names now emit warn
unknown public ingress hostnamewithserver_nameandremote_addr. Routing is unchanged.Closes #342
Post-Deploy Monitoring & Validation
A ClientHello whose SNI is not a registered lease should produce warn
unknown public ingress hostname. If that line is missing and clients still see TLS EOF on a ready URL, revert.