fix(relay-server): keep ECH wording and env-file scope

[gosunuts]

Follow-up to merged #294. One extra commit on current main. No rebase of #294 history.

• Restore the relay ECH / opt-in tunnel ECH wording in .env.example (the squash of feat(relay-server): report configuration state instead of failing silently #294 had shortened it to "ECH HTTPS records").
• --env-file isolation comments no longer claim to reproduce Compose. File-versus-shell is one question; docker compose run --rm -T portal config is the other.

evaluateFeatures is unchanged. portal.NewServer / acme.NewManager have no side-effect-free dry-run.

Closes the intent of #348 (closed: it re-landed #294's commits after the squash and conflicted).

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5b838139-1e5e-41a1-92f6-8ac0371aa170

📥 Commits

Reviewing files that changed from the base of the PR and between 9b1fea2 and 7e0ee2a.

📒 Files selected for processing (2)

• .env.example
• cmd/relay-server/config.go

Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review.

📜 Recent review details

🧰 Additional context used

📓 Path-based instructions (1)

Keep stable shared contracts, constants, and public paths in `types/`, not in runtime or helpers.

📄 CodeRabbit inference engine (AGENTS.md)

Files:

• cmd/relay-server/config.go

🔍 Remote MCP Context7, Github Grep

Additional review context

• cmp.Or is a Go standard-library generic function introduced in Go 1.22; it returns the first non-zero comparable value. The new fallback logic therefore requires Go 1.22 or newer. Verify the project’s minimum Go version.
• Repository searches did not expose go.mod, CI Go-version configuration, or matching target symbols, so compatibility could not be confirmed from the available indexed results.

🔇 Additional comments (6)

.env.example (1)

106-109: LGTM!

cmd/relay-server/config.go (5)

140-140: LGTM!

---

199-199: LGTM!

---

376-378: LGTM!

---

711-714: LGTM!

---

5-5: 🎯 Functional Correctness

No toolchain change is required for cmp.Or. go.mod and both Go builder images declare Go 1.27.0, which exceeds the Go 1.22 requirement. No older supported build path is declared.

---

📝 Walkthrough

Summary by CodeRabbit

• Documentation

  • Updated DNS provider guidance to include relay ECH records and opt-in tunnel ECH records, alongside existing ACME, managed A-record, and ENS automation options.

• Improvements

  • Improved configuration handling for default ACME provider selection and environment-file parsing.
  • Clarified configuration isolation behavior when applying relay defaults.

Walkthrough

Changes

Relay configuration updates

Layer / File(s)	Summary
Configuration fallback and environment parsing cmd/relay-server/config.go	Provider defaults now use cmp.Or. Quoted environment values use separate quote checks. The isolation comment now describes relay defaults accurately.
DNS provider documentation .env.example	The DNS provider description now includes relay ECH records and opt-in tunnel ECH records.

Merge Risk: ⚪ Minimal · up to 7e0ee

This localized configuration and documentation update introduces no actionable merge-blocking risk and is merge-ready after normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 25.00% which is insufficient. The required threshold is 70.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 1 files. (1 skipped: 1…	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title uses Conventional Commits syntax and accurately describes the ECH wording and env-file scope changes.
Description check	✅ Passed	The description is directly related to the changeset and explains the documentation, env-file isolation, and validation updates.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 25.00% which is insufficient. The required threshold is 70.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 1 files. (1 skipped: 1 unsupported.)

• Fix all pre-merge checks with AI

✨ Finishing Touches

✨ Simplify code

• Create PR with simplified code
• Commit simplified code in branch fix/config-report-env-file-scope

Warning

Some tools did not complete. Review the errors below.

🔧 golangci-lint (2.12.2)

Error: can't load config: the Go language version (go1.26) used to build golangci-lint is lower than the targeted Go version (1.27.0)
The command is terminated due to an error: can't load config: the Go language version (go1.26) used to build golangci-lint is lower than the targeted Go version (1.27.0)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}