-
Notifications
You must be signed in to change notification settings - Fork 28
feat(discovery): add IVNP relay overlay #359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,6 +26,8 @@ services: | |
| PORTAL_FRONTEND_DIR: ${PORTAL_FRONTEND_DIR:-} | ||
| BOOTSTRAPS: ${BOOTSTRAPS:-} | ||
| DISCOVERY: ${DISCOVERY:-false} | ||
| IVNP_ENABLED: ${IVNP_ENABLED:-false} | ||
| IVNP_CONFIG: ${IVNP_CONFIG:-} | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win Keep the custom IVNP destination on persistent storage.
Reject custom paths outside 🤖 Prompt for AI Agents |
||
| IDENTITY_PATH: ${IDENTITY_PATH:-/portal-certs} | ||
|
|
||
| API_PORT: 4017 | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Report IVNP as blocked on Windows.
ivnpFeaturereaches this assignment whenIVNP_ENABLED=trueandDISCOVERY=true, but the Windowsoverlay.NewIVNPimplementation always returnsivnp overlay is not supported on windows.portal.NewServerpropagates that error before startup completes. Add a Windows limitation check before reportingstateEnabled, and setstateBlockedwith a usefulMissingmessage.🤖 Prompt for AI Agents