refactor: update timer definitions to use defineReplacingNative and verify configurability in e2e tests

Author: lemon-mint

test/e2e/proxy.test.js

@@ -3706,6 +3706,23 @@ test('browser traffic uses internal SOCKS5 mode and covers proxied runtime integ
   const proxyRawDiff = await readDifferential(page);
   const proxyDiff = comparableDifferential(proxyRawDiff);
   assert.deepEqual(await readFingerprintReport(page), proxyRawDiff.surface.fingerprint);
+  assert.deepEqual(
+    await page.evaluate(() => {
+      const out = {};
+      for (const name of ['setTimeout', 'setInterval']) {
+        const descriptor = Object.getOwnPropertyDescriptor(window, name);
+        Object.defineProperty(window, name, {
+          value: descriptor.value,
+          enumerable: descriptor.enumerable,
+          configurable: descriptor.configurable,
+          writable: descriptor.writable,
+        });
+        out[name] = Object.getOwnPropertyDescriptor(window, name).configurable;
+      }
+      return out;
+    }),
+    { setTimeout: true, setInterval: true },
+  );
   assert.equal(proxyDiff.surface.workerRealm.imported.loaded, true);
   assert.ok(
     requests.some((r) => r.url === '/worker-imported-fixture.js' && r.userAgent === TARGET_UA),

test/js/static-policy.test.js

@@ -242,7 +242,8 @@ test('runtime installs required escape-vector hooks', () => {
     '__zp_runClassic',
     '__zp_get',
     '__zp_assign',
-    "define(root, 'setTimeout'",
+    "defineReplacingNative(root, 'setTimeout'",
+    "defineReplacingNative(root, 'setInterval'",
     'installDocumentWriteHooks',
     'createContextualFragment',
     'parseFromString',

web/runtime/dynamic-code/facade.mjs

@@ -189,12 +189,12 @@ export function createDynamicCodeFacade({
     defineReplacingNative(root, 'Function', dynamicFunction);
     installDynamicConstructorBackrefs();
     if (Native.setTimeout) {
-      define(root, 'setTimeout', function(handler, delay, ...args) {
+      defineReplacingNative(root, 'setTimeout', function(handler, delay, ...args) {
         return Native.setTimeout(typeof handler === 'string' ? compileTimerString(handler) : handler, delay, ...args);
       });
     }
     if (Native.setInterval) {
-      define(root, 'setInterval', function(handler, delay, ...args) {
+      defineReplacingNative(root, 'setInterval', function(handler, delay, ...args) {
         return Native.setInterval(typeof handler === 'string' ? compileTimerString(handler) : handler, delay, ...args);
       });
     }