test: add test for OXC rewriter's handling of cache-busting query strings

feat: implement parserFilename function for improved filename handling

Author: lemon-mint

test/js/rewriter.test.js

@@ -38,6 +38,15 @@ test('OXC rewriter supports modules and fails closed on parse errors', async ()
   assert.equal(bad.errorCode, 'PARSE_FAILED');
   assert.match(rewriter.blockSource(), /Blocked by ZeroProxy rewrite policy/);
 });
+test('OXC rewriter accepts target URLs with cache-busting query strings', async () => {
+  const rewriter = await loadRewriter();
+  const out = rewriter.rewriteScript(`window.location = "/next";`, {
+    kind: 'classic',
+    targetUrl: 'https://ipleak.net/static/js/index.js?ts=20220812#frag',
+  });
+  assert.equal(out.ok, true, JSON.stringify(out.diagnostics));
+  assert.match(out.code, /__zp_set\(__zp_get\(globalThis,"window"\),"location","\/next"\)/);
+});
 
 test('OXC rewriter blocks constructor escape compound writes', async () => {
   const rewriter = await loadRewriter();

web/js-rewriter.js

@@ -79,9 +79,20 @@
     return ok(rewritten.code.slice(prefix.length, rewritten.code.length - suffix.length), parsed.diagnostics.concat(rewritten.diagnostics));
   }
 
+  function parserFilename(filename) {
+    let value = String(filename || 'target.js');
+    let end = value.length;
+    const query = value.indexOf('?');
+    const hash = value.indexOf('#');
+    if (query !== -1 && query < end) end = query;
+    if (hash !== -1 && hash < end) end = hash;
+    if (end !== value.length) value = value.slice(0, end);
+    return value && !value.endsWith('/') && !value.endsWith('\\') ? value : 'target.js';
+  }
+
   function parse(source, sourceType, filename) {
     let result;
-    try { result = parser.parseSync(source, { sourceType, sourceFilename: filename || 'target.js' }); }
+    try { result = parser.parseSync(source, { sourceType, sourceFilename: parserFilename(filename) }); }
     catch (err) { return blocked('PARSE_FAILED', [{ level: 'error', message: err && err.message || 'PARSE_FAILED' }]); }
     const errors = result.errors || [];
     if (errors.length) return blocked('PARSE_FAILED', errors.map(e => ({ level: e.severity || 'error', message: e.message || 'PARSE_FAILED', start: e.start, end: e.end })));