refactor: replace execSync with spawnSync for improved command execution and error handling

Author: lemon-mint

scripts/test.mjs

@@ -1,29 +1,46 @@
-import { execSync } from 'node:child_process';
+import { spawnSync } from 'node:child_process';
 
 const mode = process.argv[2] || 'all';
 const env = Object.fromEntries(Object.entries(process.env).filter(([key]) => !key.startsWith('npm_')));
 
 function run(cmd, allowRetry = false) {
-  try {
-    execSync(cmd, {
-      cwd: process.cwd(),
-      stdio: 'inherit',
-      env,
-      shell: '/bin/bash',
-    });
-  } catch (err) {
-    const msg = String(err && err.message || err || '');
-    if (allowRetry && /ECONNRESET/.test(msg)) {
-      execSync(cmd, {
-        cwd: process.cwd(),
-        stdio: 'inherit',
-        env,
-        shell: '/bin/bash',
-      });
-      return;
-    }
-    throw err;
+  const first = runOnce(cmd);
+  if (first.status === 0) return;
+  if (allowRetry && /\bECONNRESET\b/.test(resultText(first))) {
+    process.stderr.write('\nRetrying after transient ECONNRESET from browser/relay test transport...\n');
+    const second = runOnce(cmd);
+    if (second.status === 0) return;
+    throw commandError(cmd, second);
   }
+  throw commandError(cmd, first);
+}
+
+function runOnce(cmd) {
+  const result = spawnSync(cmd, {
+    cwd: process.cwd(),
+    env,
+    shell: '/bin/bash',
+    encoding: 'utf8',
+    maxBuffer: 64 * 1024 * 1024,
+  });
+  if (result.stdout) process.stdout.write(result.stdout);
+  if (result.stderr) process.stderr.write(result.stderr);
+  if (result.error) throw result.error;
+  return result;
+}
+
+function resultText(result) {
+  return `${result.stdout || ''}\n${result.stderr || ''}`;
+}
+
+function commandError(cmd, result) {
+  const err = new Error(`Command failed: ${cmd}`);
+  err.status = result.status;
+  err.signal = result.signal;
+  err.output = [null, result.stdout, result.stderr];
+  err.stdout = result.stdout;
+  err.stderr = result.stderr;
+  return err;
 }
 
 if (mode === 'js') {