Skip to content

Commit de898d9

Browse files
authored
Merge pull request #36 from gotvinne/got/rename-linter
Rename linter
2 parents 1546b8e + f766947 commit de898d9

4 files changed

Lines changed: 5 additions & 11 deletions

File tree

.github/workflows/check.yaml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,8 @@ jobs:
1111
steps:
1212
- name: Checkout code
1313
uses: actions/checkout@v4
14-
1514
- name: Install clang-format
1615
run: sudo apt-get install -y clang-format
17-
1816
- name: Check formatting in /src
1917
run: |
2018
find ./src \( -iname '*.h' -o -iname '*.cpp' \) -print0 | xargs -0 clang-format --dry-run --Werror
@@ -25,25 +23,20 @@ jobs:
2523
steps:
2624
- name: Checkout code
2725
uses: actions/checkout@v4
28-
2926
- name: install build dependancies
3027
run: sudo apt install gcc python3 cmake gcc-arm-none-eabi binutils-arm-none-eabi
31-
3228
- name: microinstall
3329
run: |
3430
chmod +x microinstall.sh
3531
./microinstall.sh
36-
3732
- name: Add micro-tools to path
3833
run: |
3934
source ./aliases.sh
4035
chmod +x ./aliases.sh
4136
./aliases.sh
42-
4337
- name: Copy src foldet to sdk
4438
run: |
4539
rsync -a --delete ./src/ ./microbit-v2-sdk/source/
46-
4740
- name: microbuild python
4841
run: |
4942
cd microbit-v2-sdk

README.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,8 @@ Feed in filepath to microbit-v2-sdk: /Users/geirolatvinnereim/AirBit/microbit-v2
6666

6767
If nrf_sdh_soc_init() cannot be found. You have called build from a wrong folder. Chech microbit-v2-sdk/source and assure that only the src/.cpp files are present.
6868

69+
If there are build errors in the Codal SDK. There are probably some conflicting file names or methods which causes build errors. Delete the build folder produces in /microbit-v2-sdk and rebuild.
70+
6971
### Debugging
7072

7173
In order allow debugging, the project needs to be built by navigating into the microbit-v2-sdk and access debugger inside Visual Studio Code.
@@ -79,8 +81,7 @@ python3 build.py
7981
We want to utilize a dynamic analysis tool, which can linter codebase, not a static one
8082

8183
Using **clang-format** as dynamic cpp-linter. install and usage:
82-
This command line tool can only linter one file at a time, so we need to apply recursiveness
84+
This command line tool can only linter one file at a time, so we need to apply recursiveness at src
8385
```console
84-
brew install clang-format
85-
find /Users/geirolatvinnereim/AirBit/src -iname '*.h' -o -iname '*.cpp' | xargs clang-format -i
86+
./linter.sh
8687
```

formatting.sh

Lines changed: 0 additions & 1 deletion
This file was deleted.

linter.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
find ./src -iname '*.h' -o -iname '*.cpp' | xargs clang-format -i

0 commit comments

Comments
 (0)