Commit c131053
committed
fix(runs): mid-resume progress polling was missing on the canonical inspector
Convergence audit against PR opensearch-project#414 (checkpoint-resume): EvalRunDetailPage
has always polled every 3s while status === 'running' so pass/fail
counts and per-test-case statuses update live during/after a resume
without a manual reload. RunInspectorPage had no equivalent — clicking
Resume there updated nothing until resumeEvaluationRun()'s whole SSE
stream settled, since the client call passes a no-op progress callback
(true on both pages; opensearch-project#414 never wired up onStarted/onProgress).
Adds the same running-poll to RunInspectorPage (evalRun mode only), but
improves on the source pattern instead of copying its flaw: loadData()
now takes a { silent } option that skips the full-page loading-skeleton
flip, so a background refresh doesn't blow away the user's open
test-case selection every 3s (EvalRunDetailPage's loadRun() does flip
loading on every poll tick — harmless there since it has no left/right
selection state to lose, but would have been disruptive on the
two-pane inspector). The post-resume-click refreshes are silent too.
Signed-off-by: Megha Goyal <goyamegh@amazon.com>1 parent ce35115 commit c131053
1 file changed
Lines changed: 23 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
117 | 117 | | |
118 | 118 | | |
119 | 119 | | |
120 | | - | |
121 | | - | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
122 | 125 | | |
123 | | - | |
| 126 | + | |
124 | 127 | | |
125 | 128 | | |
126 | 129 | | |
| |||
251 | 254 | | |
252 | 255 | | |
253 | 256 | | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
254 | 270 | | |
255 | 271 | | |
256 | 272 | | |
| |||
311 | 327 | | |
312 | 328 | | |
313 | 329 | | |
314 | | - | |
315 | | - | |
316 | | - | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
317 | 334 | | |
318 | 335 | | |
319 | 336 | | |
| |||
0 commit comments