Add reversible legend option - #86
Draft
matschaffer wants to merge 3 commits into
Draft
Conversation
Collaborator
Author
|
Ah, just noticed the |
matschaffer
marked this pull request as draft
December 27, 2020 06:52
matschaffer
marked this pull request as ready for review
December 27, 2020 08:21
Collaborator
Author
|
Ah nice. Now that I see which test handles this I’ll add something to test reversibility too. |
matschaffer
marked this pull request as draft
December 27, 2020 09:12
|
Dear Mat, thanks a stack for this contribution.
That would be super nice! With kind regards, |
Let's us clean up the generation code a bit without having to worry about whitespace.
|
Dear Mat, do you also believe this patch would be ready to go? Currently, the PR is still in "Draft" state. With kind regards, |
Collaborator
Author
|
I'd have to double check. I think it might have been failing tests last I looked, but it seems green here so not sure. |
|
Hi Mat, indeed, the tests seem to have succeeded. So, maybe just let us remove the "Draft" flag and finally merge the patch? With kind regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #85