Repository navigation
Update MailKit to 4.18.2 and keep e-mails out of OIDC sync logs - #985
Merged
Merged
Conversation
… of OIDC sync logs MailKit 4.18.1 pulls System.Security.Cryptography.Pkcs 10.0.0 transitively; pin the serviced 10.0.13 release next to the existing Cryptography.Xml pin. The OpenID Connect profile synchronizer logged the customer's current and the identity provider's e-mail address when it refused to change it; the customer ids are enough.
…phy.Pkcs MailKit 4.18.2 depends on MimeKit 4.18.2, which requires System.Security.Cryptography.Pkcs 10.0.13, so the explicit pin is no longer needed.
KrzysztofPajak
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: bugfix
Issue
MailKit4.18.1 pullsSystem.Security.Cryptography.Pkcs10.0.0 transitively (throughMimeKit4.18.1) intoGrand.Business.Messagesand everything above it.dotnet list package --vulnerable --include-transitivereports it against GHSA-846f-f764-76mx (high) and GHSA-2fmv-rv2c-59x7 (moderate); both are fixed in 10.0.13.cs/exposure-of-sensitive-informationinOidcProfileSynchronizer.cs.Solution
MailKitto 4.18.2. It depends onMimeKit4.18.2, which requiresSystem.Security.Cryptography.Pkcs10.0.13, so no explicit pin is needed.{CustomerId},{OtherId}). The test for the "taken by another customer" case now asserts that no e-mail reaches the log.Breaking changes
None. The log message templates changed; nothing parses them.
Testing
dotnet list GrandNode.slnx package --vulnerable --include-transitive: all projects report no vulnerable packages;Grand.Business.MessagesresolvesSystem.Security.Cryptography.Pkcs10.0.13.dotnet test src/Tests/Grand.Web.Common.Tests: all tests pass, includingOidcProfileSynchronizerTests.