Repository navigation
Validate throttle capacity and refill period before initialization - #391
Open
Sarbajit-Sengupta wants to merge 2 commits into
Open
Sarbajit-Sengupta wants to merge 2 commits into
Sarbajit-Sengupta wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invalid throttle settings are accepted into the persisted bucket or fail with an incidental division error. Zero/negative periods and non-finite values cannot define a usable refill rate; a capacity below one cannot hold a complete token.
Validate a finite capacity of at least one and a finite positive refill period before writing the bucket. Raise a parameter-specific
ValueError. Add nine invalid-input cases that also verify the cache remains untouched, plus three valid configurations including a fractional period and a fractional capacity above one.Validation: nine regressions fail before the change; 191 core/Fanout/Deque/Index/recipe tests pass on Python 3.13. Blue's formatter API and equivalent Ruff style checks pass. Django integration tests were not run because the dependency download repeatedly reset.