Repository navigation
Make _add_sharable_to_page_info_type idempotent - #31
Open
tsauerwein wants to merge 1 commit into
Open
tsauerwein wants to merge 1 commit into
tsauerwein wants to merge 1 commit into
Conversation
So far, `build_schema` would raise an error if it was called multiple times with a schema using PageInfo, because it tried to add the `@sharable` directive multiple times to PageInfo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we tried to build our schema with
graphene_federation.build_schema, an error would be raised:It turns out that if _add_sharable_to_page_info_type is called a second time, it would fail because the
@sharabledirective had already been added to thePageInfotype.This PR suggests to first check if the directive has already been added to
PageInfo.