Skip to content

fix: align minified source location at chunk boundaries - #4915

Open
fallintoplace wants to merge 1 commit into
graphql:17.x.xfrom
fallintoplace:fix/minified-location-column-boundaries-20261024
Open

fallintoplace wants to merge 1 commit into
graphql:17.x.xfrom
fallintoplace:fix/minified-location-column-boundaries-20261024

Conversation

@fallintoplace

Copy link
Copy Markdown
Contributor

What

Fix the caret position at 80-character chunk boundaries in minified source errors.

Why

Columns 80 and 160 currently place the caret on the next chunk instead of the character where the error occurred.

Implementation

  • Convert the 1-based column to a 0-based offset before calculating the chunk and caret position.
  • Add regression coverage for columns 80 and 160.

@vercel

vercel Bot commented Oct 24, 2026

Copy link
Copy Markdown

@fallintoplace is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel.

A member of the Team first needs to authorize it.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant