Skip to content

Commit dba2bd1

Browse files
chore(deps): run the visual tests against uikit 7.48 (#246)
* fix(SubmitButton): keep the loading spinner visible on uikit 7.48 uikit 7.48 moved the spinner colour out of `--g-color-line-brand` into its own `--g-spin-color`, falling back to `--g-color-base-brand`. The override stopped applying, so the spinner took the brand colour of the button it sits on and became invisible. Both variables are set now, so the spinner keeps its contrast across the whole `^7.25.0` peer range. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(hooks): accept the Label xxs size from uikit 7.48 uikit 7.48 added `xxs` to `LabelProps['size']`, which no longer fits the `ControlSize` constraint of the size helpers, so `ContextItem` failed to typecheck. The size is listed in `ControlSize` now. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * test(playwright): wait for overlay transitions before capturing uikit overlays fade in from `opacity: 0`, and Playwright already reports a fully transparent node as visible, so `expect(dialog).toBeVisible()` released the capture mid-transition and an empty page ended up in the screenshot. On uikit 7.48 that made 13 of 36 runs of the dialog specs fail; waiting for the mounted overlays to reach `opacity: 1` first takes it to 0 of 150. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * chore(deps): run the visual tests against uikit 7.48 The dev dependency resolved to 7.25.0, the very bottom of the supported range, so the visual tests never saw any of the markup uikit changed since. The peer range stays at `^7.25.0`, both markups have to keep working. None of the 346 snapshots had to be re-recorded once the regressions the bump uncovered were fixed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * test(History): wait for the popup to settle before hovering Hovering a chat item while the history popup is still fading in makes Chromium decide the item is not fully visible and scroll it into view. That scrolls the inner list by the height of the first date group and the page by 78px, and the list keeps that offset for the rest of the test, so the group is cut off the screenshot. The two delete tests failed 2 of 8 runs on uikit 7.25 and 8 of 8 on 7.48, which only widens the window: the popup gained a transform transition. `retries: 2` has been hiding it on CI. Waiting for the popup to reach `opacity: 1` before the first hover takes both to 0 of 20 under parallel load. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> --------- Co-authored-by: i-doshechnikow <i-doshechnikow@users.noreply.github.com> Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
1 parent 3b2ae89 commit dba2bd1

6 files changed

Lines changed: 503 additions & 12 deletions

File tree

0 commit comments

Comments
 (0)