Repository navigation
Conversation
Generated with RN 0.87.1's `react-native spm scaffold` from the podspec and validated with `swift package dump-package` (swift-tools-version 6.0). The two React path dependencies resolve through RN 0.87's autolinking alias at app resolve time (same shape react-native-safe-area-context ships); they do not resolve in a bare clone. CocoaPods users are unaffected. Needed for React Native 0.87 SwiftPM autolinking, where autolinked native libraries without a manifest fail the package resolve.
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The SwiftPM target omits the library’s privacy manifest resource.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds SwiftPM support for React Native 0.87 autolinking while retaining CocoaPods support.
Changes:
- Adds a Swift 6 package manifest for the iOS native module.
- Adds an Objective-C prefix header for SwiftPM compilation.
| File | Description |
|---|---|
Package.swift |
Defines the SwiftPM library target and React Native dependencies. |
react-native-spm-prefix.h |
Supplies implicit Foundation and UIKit imports. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| "ios/RNViewShot.h", | ||
| "ios/RNViewShot.mm", | ||
| ], | ||
| publicHeadersPath: "ios", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
Package.swift+ the scaffold prefix header for react-native-view-shot 6.0.1, generated with RN 0.87.1'sreact-native spm scaffold(RN's documented path for community libraries) and validated withswift package dump-package(swift-tools-version 6.0).