Skip to content

feat(labels): add printable label offset for partially used sheets - #18781

Open
BlackFenix2 wants to merge 1 commit into
grokability:masterfrom
BlackFenix2:master
Open

feat(labels): add printable label offset for partially used sheets#18781
BlackFenix2 wants to merge 1 commit into
grokability:masterfrom
BlackFenix2:master

Conversation

@BlackFenix2

Copy link
Copy Markdown

I noticed when using Avery sheets or any other multi label page, I have been unable to re-use sheets if i did not print all of the label slots available.

I added a simple offset option to skip empty positions on a partially used sheet. This works fine for multiple labels per page and does not cause breaks with tapes like the brother TZE label generations.

I did use copilot to help find the controller that handles generating the bulk label PDF. I tested the implementation on my dev server and provided screenshots as proof. Please let me know if you have any questions.

image image

@BlackFenix2
BlackFenix2 requested a review from snipe as a code owner March 28, 2026 17:02
@codacy-production

codacy-production Bot commented Apr 2, 2026

Copy link
Copy Markdown

Not up to standards ⛔

🔴 Issues 1 minor

Alerts:
⚠ 1 issue (≤ 0 issues of at least minor severity)

Results:
1 new issue

Category Results
CodeStyle 1 minor

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

@r-xyz

r-xyz commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Thanks @BlackFenix2 for starting this PR; looking forward to see this functionality merged as it adds #18013

Would you have time to clean it up and finalize it? I would be happy to help or start a new one otherwise. :)

@jl-stellar

Copy link
Copy Markdown

As far as I can tell, the error reported by "Codacy" is this line (L 17 in resources/views/hardware/labels.blade.php):
$total_labels = count($assets) + $offset;
Since the message reads "operation must be bracketed", I assume that this would fix it:
$total_labels = (count($assets) + $offset);

@snipe

snipe commented Jul 17, 2026

Copy link
Copy Markdown
Member

This would also need to be targeted to the develop branch, per the dev documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants