Skip to content

Fixed #19518 - added support for SASL LDAP - #19556

Open
snipe wants to merge 3 commits into
developfrom
#19518-sasl-without-credentials
Open

Fixed #19518 - added support for SASL LDAP#19556
snipe wants to merge 3 commits into
developfrom
#19518-sasl-without-credentials

Removed checkbox, refactor for common static method for shouldUseSasl…

1eb42d2
Select commit
Loading
Failed to load commit list.
Codacy Production / Codacy Static Code Analysis required action Aug 26, 2026 in 0s

1 new issue (0 max.) of at least severity.

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
- Added 1
           

Complexity increasing per file
==============================
- app/Console/Commands/LdapTroubleshooter.php  8
- tests/Unit/LdapTest.php  3
- app/Models/Ldap.php  7
- app/Livewire/LdapSettings.php  4
         

See the complete overview on Codacy

Annotations

Check notice on line 775 in app/Livewire/LdapSettings.php

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

app/Livewire/LdapSettings.php#L775

The method runStep2NetworkTest uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.