|
18 | 18 | SmgModbusDriver, |
19 | 19 | _apply_capability_read_back, |
20 | 20 | _decode_block, |
| 21 | + _read_optional_specs, |
21 | 22 | _support_capture_ranges, |
22 | 23 | ) |
23 | 24 | from custom_components.eybond_local.drivers.read_result import ( # noqa: E402 |
|
36 | 37 | set_external_register_schema_roots, |
37 | 38 | ) |
38 | 39 | from custom_components.eybond_local.models import DetectedInverter, ProbeTarget # noqa: E402 |
39 | | -from custom_components.eybond_local.payload.modbus import crc16_modbus # noqa: E402 |
| 40 | +from custom_components.eybond_local.payload.modbus import ( # noqa: E402 |
| 41 | + ModbusError, |
| 42 | + crc16_modbus, |
| 43 | +) |
40 | 44 | from custom_components.eybond_local.telemetry import ( # noqa: E402 |
41 | 45 | TelemetryFreshness, |
42 | 46 | TypedTelemetryFrame, |
@@ -528,6 +532,85 @@ async def test_issue_13_sandisolar_fingerprint_uses_protocol_4_schema(self) -> N |
528 | 532 | self.assertEqual(values["inverter_temperature"], 35) |
529 | 533 | self.assertNotEqual(values["inverter_temperature"], 5001) |
530 | 534 |
|
| 535 | + async def test_issue_13_sandisolar_timeout_does_not_fan_out_optional_reads( |
| 536 | + self, |
| 537 | + ) -> None: |
| 538 | + """One silent session must not become a 55-register timeout cascade.""" |
| 539 | + |
| 540 | + driver = SmgModbusDriver() |
| 541 | + target = ProbeTarget(devcode=0x0001, collector_addr=0xFF, device_addr=0x01) |
| 542 | + inverter = DetectedInverter( |
| 543 | + driver_key="modbus_smg", |
| 544 | + protocol_family="modbus_smg", |
| 545 | + model_name="Sandisolar SD 11KP48V WIFI", |
| 546 | + serial_number="92B32511113147", |
| 547 | + probe_target=target, |
| 548 | + variant_key="sandisolar_sd_11kp48v_wifi", |
| 549 | + profile_name="modbus_smg/models/sandisolar_sd_11kp48v_wifi.json", |
| 550 | + register_schema_name=( |
| 551 | + "modbus_smg/models/sandisolar_sd_11kp48v_wifi.json" |
| 552 | + ), |
| 553 | + capabilities=(), |
| 554 | + ) |
| 555 | + schema = load_register_schema(inverter.register_schema_name) |
| 556 | + self.assertEqual(len(schema.spec_set("aux_config")), 55) |
| 557 | + |
| 558 | + class _Session: |
| 559 | + def __init__(self) -> None: |
| 560 | + self.calls: list[tuple[int, int]] = [] |
| 561 | + |
| 562 | + async def read_holding(self, register: int, count: int) -> list[int]: |
| 563 | + self.calls.append((register, count)) |
| 564 | + if (register, count) in {(100, 10), (198, 34), (600, 57)}: |
| 565 | + return [0] * count |
| 566 | + raise ModbusError("request_timeout") |
| 567 | + |
| 568 | + session = _Session() |
| 569 | + with patch.object( |
| 570 | + SmgModbusDriver, |
| 571 | + "_session", |
| 572 | + staticmethod(lambda *_args, **_kwargs: session), |
| 573 | + ): |
| 574 | + with self.assertRaisesRegex(ModbusError, "^request_timeout$"): |
| 575 | + await driver.async_read_values(object(), inverter) |
| 576 | + |
| 577 | + self.assertEqual( |
| 578 | + session.calls, |
| 579 | + [(100, 10), (198, 34), (600, 57), (171, 1)], |
| 580 | + ) |
| 581 | + |
| 582 | + async def test_explicit_optional_group_rejection_keeps_single_read_fallback( |
| 583 | + self, |
| 584 | + ) -> None: |
| 585 | + """An explicit illegal-range reply may still isolate supported fields.""" |
| 586 | + |
| 587 | + schema = load_register_schema( |
| 588 | + "modbus_smg/models/sandisolar_sd_11kp48v_wifi.json" |
| 589 | + ) |
| 590 | + specs = tuple( |
| 591 | + spec |
| 592 | + for spec in schema.spec_set("aux_config") |
| 593 | + if 252 <= spec.register <= 256 |
| 594 | + ) |
| 595 | + self.assertEqual(len(specs), 5) |
| 596 | + |
| 597 | + class _Session: |
| 598 | + def __init__(self) -> None: |
| 599 | + self.calls: list[tuple[int, int]] = [] |
| 600 | + |
| 601 | + async def read_holding(self, register: int, count: int) -> list[int]: |
| 602 | + self.calls.append((register, count)) |
| 603 | + if count > 1: |
| 604 | + raise ModbusError("exception_code:2") |
| 605 | + return [register] |
| 606 | + |
| 607 | + session = _Session() |
| 608 | + values = await _read_optional_specs(session, specs) |
| 609 | + |
| 610 | + self.assertEqual(session.calls[0], (252, 5)) |
| 611 | + self.assertEqual(session.calls[1:], [(register, 1) for register in range(252, 257)]) |
| 612 | + self.assertEqual(set(values), {spec.key for spec in specs}) |
| 613 | + |
531 | 614 | async def test_probe_selects_hhs_11kw_telemetry_without_anj_controls(self) -> None: |
532 | 615 | driver = SmgModbusDriver() |
533 | 616 | target = ProbeTarget(devcode=0x0001, collector_addr=0xFF, device_addr=0x01) |
|
0 commit comments