Repository navigation
Conversation
groove-max
left a comment
There was a problem hiding this comment.
Thanks for putting this together, and sorry for the slow review. The smaller read blocks and settings readbacks look useful. There are a few things to address before we can merge this:
- Please submit the source changes against current
main. Right now the PR adds a.patchfile, so merging it would not actually enable the support. - Keep the SMX-II profile separate from generic SRNE support and select it only from reliable device identification. The battery controls currently assume a 24 V system (20–33 V limits), which we can't safely apply to every SRNE inverter. Please include tests showing that other or unidentified SRNE devices don't receive these controls.
- Keep the controls untested unless we have confirmation for the matching device and commands. The attached support archive was collected through the SMG driver; it doesn't establish the SRNE configuration registers or the successful writes needed for the two
tested=trueflags.
The controls can be part of the contribution, but their availability needs to be qualified separately from telemetry, rather than enabled across the whole family. I'll leave the PR open for an updated version.
|
ok I also have an Anenji 5 kW inverter and have been seeing occasional collector disconnects. One possible cause is the periodic Wi-Fi scan: I disabled this query from runtime polling and left Wi-Fi scans available only on demand in the settings flow:
- CollectorAtQueryDefinition(
- "INTPARA49",
- "Nearby Wi-Fi scan list reported by the collector.",
- _decode_text_value("collector_wifi_scan_list"),
- frozenset({"collector_wifi_scan_list"}),
- ),
+ # Keep Wi-Fi scans on demand in the settings flow, not background polling.This may help avoid unnecessary load on the collector and reduce disconnects. |
Added support for Easun iSolar SMX-II 3.6kw
Якщо що, мiй телеграм tac2sc
01M3CFTB76M49ZSWYE42GR0DBQ_20260925T143722836190Z.zip
Verification: