Repository navigation
feat: bind Anenji GES48120 to Sumry/GES 0x7530 via identity anchors - #55
Conversation
Qualify automatic read-only detection with exact model 45 / class 10 / protocol 220 captures and keep the existing 0x7530 evidence subset. Co-authored-by: Cursor <cursoragent@cursor.com>
groove-max
left a comment
There was a problem hiding this comment.
Thanks for putting this together and testing it on your inverter! This follows the approach we discussed: three exact identity anchors, the existing catalog driver, and the nine-field read-only subset. No transport changes or extra write registers have slipped in.
The 14 focused tests and 191 Home Assistant tests passed locally. I've also enabled the GitHub CI run. There are just a few small things to finish before merging:
- Update the Unreleased changelog entry,
docs/architecture/SUMRY_GES_7530.md, the description indocs/README.md, and the test module's opening description. They still say automatic detection is blocked. Please describe the new exact-match, read-only support while keeping the remaining telemetry/control limitations clear. - In
test_identity_bad_crc_does_not_bind, change a CRC byte without shortening the response. The currentresponse[:-1]checks a truncated frame, not a full-length frame with an invalid checksum. Keeping both cases as separate tests would be ideal. I checked the full-length bad-CRC case separately and it is rejected correctly; this is about retaining that regression coverage. - Point the new identity source at the actual capture comment, using
project-comment:5953299167, so the evidence is easy to trace.
No broader refactor or additional device captures are needed for this PR. The scope looks good.
Address PR review: refresh changelog and architecture docs, split truncated vs bad-CRC identity tests, and point the identity source at comment 5953299167. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Thanks for the review — addressed in 5f85a01:
Happy to wait for CI / merge as-is. Separately (not in this PR): my dashboard needs a few more read-only fields
Would you prefer those as a follow-up PR after this merges, still read-only |
groove-max
left a comment
There was a problem hiding this comment.
Thanks for addressing all three review points. I checked the merge with the current main: the full quality gate and all 210 Home Assistant tests pass, and GitHub CI is green. The three exact identity anchors and nine-field read-only scope are intact. Approved.
|
Merged into main — thank you for the captures, hardware testing and the focused PR! This is available in the test code now; no new release has been published. Yes, a small follow-up PR for the additional read-only fields would be welcome. Please include the register/scaling evidence and missing-data tests. For a two-leg mains total, both legs must be available in the same read; do not fall back to a one-leg total. Keeping this separate from write support will make it much easier to review. |
Summary
0xC738/0xC739and0xC768)sumry_ges_7530evidence subset (9 sensors: battery + phase-A output/mains); no write profileTest plan
python3 tools/model_catalog.py validatepython3 -m unittest tests.test_sumry_ges_7530equalsanchors are requiredMade with Cursor