Skip to content

Commit 247d324

Browse files
petedmarshXirp Agent (gpt-6.1-sol)
andauthored
netty: Increase HPACK encoder bucket count to 64 (#13077)
Increase the HPACK encoder bucket count from 16 to 64 for both clients and servers, matching Netty’s new default. On newer Netty versions, this permits encoder tables up to 4 KiB within the peer’s advertised limit. Advertised table sizes and the Netty dependency version are unchanged. Use 64 rather than 128 following review: the adjusted benchmark showed comparable performance, while larger dynamic tables need improvements to Netty’s encoder. Related to #12973. Discovered by @ejona86. Co-authored-by: Xirp Agent (gpt-6.1-sol) <xirp-agent@users.noreply.ghe.spotify.net>
1 parent 6b5417f commit 247d324

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

‎netty/src/main/java/io/grpc/netty/NettyClientHandler.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ static NettyClientHandler newHandler(
176176
Http2HeadersDecoder headersDecoder = new GrpcHttp2ClientHeadersDecoder(maxHeaderListSize);
177177
Http2FrameReader frameReader = new DefaultHttp2FrameReader(headersDecoder);
178178
Http2HeadersEncoder encoder = new DefaultHttp2HeadersEncoder(
179-
sensitivityDetector(neverIndexedMetadataKeys), false, 16, Integer.MAX_VALUE);
179+
sensitivityDetector(neverIndexedMetadataKeys), false, 64, Integer.MAX_VALUE);
180180
Http2FrameWriter frameWriter = new DefaultHttp2FrameWriter(encoder);
181181
Http2Connection connection = new DefaultHttp2Connection(false);
182182
UniformStreamByteDistributor dist = new UniformStreamByteDistributor(connection);

‎netty/src/main/java/io/grpc/netty/NettyServerHandler.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ static NettyServerHandler newHandler(
189189
Http2HeadersEncoder encoder = new DefaultHttp2HeadersEncoder(
190190
NettyClientHandler.sensitivityDetector(neverIndexedMetadataKeys),
191191
false,
192-
16,
192+
64,
193193
Integer.MAX_VALUE);
194194
Http2FrameWriter frameWriter =
195195
new Http2OutboundFrameLogger(new DefaultHttp2FrameWriter(encoder), frameLogger);

0 commit comments

Comments
 (0)