Skip to content

Commit 54079b4

Browse files
petedmarshcodex
andcommitted
netty: Increase HPACK encoder bucket count to 128
Co-Authored-By: Codex <noreply@openai.com>
1 parent 4d0d548 commit 54079b4

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

‎netty/src/main/java/io/grpc/netty/NettyClientHandler.java‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,8 +175,10 @@ static NettyClientHandler newHandler(
175175
Preconditions.checkArgument(maxHeaderListSize > 0, "maxHeaderListSize must be positive");
176176
Http2HeadersDecoder headersDecoder = new GrpcHttp2ClientHeadersDecoder(maxHeaderListSize);
177177
Http2FrameReader frameReader = new DefaultHttp2FrameReader(headersDecoder);
178+
// TODO: Add support upstream in Netty for injecting a custom Http2HeadersEncoder subclass
179+
// into Http2FrameCodecBuilder before migrating to that API.
178180
Http2HeadersEncoder encoder = new DefaultHttp2HeadersEncoder(
179-
sensitivityDetector(neverIndexedMetadataKeys), false, 16, Integer.MAX_VALUE);
181+
sensitivityDetector(neverIndexedMetadataKeys), false, 128, Integer.MAX_VALUE);
180182
Http2FrameWriter frameWriter = new DefaultHttp2FrameWriter(encoder);
181183
Http2Connection connection = new DefaultHttp2Connection(false);
182184
UniformStreamByteDistributor dist = new UniformStreamByteDistributor(connection);

‎netty/src/main/java/io/grpc/netty/NettyServerHandler.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ static NettyServerHandler newHandler(
189189
Http2HeadersEncoder encoder = new DefaultHttp2HeadersEncoder(
190190
NettyClientHandler.sensitivityDetector(neverIndexedMetadataKeys),
191191
false,
192-
16,
192+
128,
193193
Integer.MAX_VALUE);
194194
Http2FrameWriter frameWriter =
195195
new Http2OutboundFrameLogger(new DefaultHttp2FrameWriter(encoder), frameLogger);

0 commit comments

Comments
 (0)