Skip to content

Commit 54b220c

Browse files
petedmarshXirp Agent (gpt-6.1-sol)
andcommitted
netty: Remove obsolete HPACK encoder migration TODO
The encoder now uses 64 buckets, matching the Netty default, so migrating to Http2FrameCodecBuilder no longer requires custom encoder injection for the bucket count. Co-Authored-By: Xirp Agent (gpt-6.1-sol) <xirp-agent@users.noreply.ghe.spotify.net>
1 parent 4b494c1 commit 54b220c

1 file changed

Lines changed: 0 additions & 2 deletions

File tree

‎netty/src/main/java/io/grpc/netty/NettyClientHandler.java‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -175,8 +175,6 @@ static NettyClientHandler newHandler(
175175
Preconditions.checkArgument(maxHeaderListSize > 0, "maxHeaderListSize must be positive");
176176
Http2HeadersDecoder headersDecoder = new GrpcHttp2ClientHeadersDecoder(maxHeaderListSize);
177177
Http2FrameReader frameReader = new DefaultHttp2FrameReader(headersDecoder);
178-
// TODO: Add support upstream in Netty for injecting a custom Http2HeadersEncoder subclass
179-
// into Http2FrameCodecBuilder before migrating to that API.
180178
Http2HeadersEncoder encoder = new DefaultHttp2HeadersEncoder(
181179
sensitivityDetector(neverIndexedMetadataKeys), false, 64, Integer.MAX_VALUE);
182180
Http2FrameWriter frameWriter = new DefaultHttp2FrameWriter(encoder);

0 commit comments

Comments
 (0)