Skip to content

netty: enable AdaptiveCumulator #13100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shivaspeaks merged 3 commits into from
Oct 9, 2026
Merged

netty: enable AdaptiveCumulator #13100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
755637d
netty: enable AdaptiveCumulator
shivaspeaks Oct 8, 2026
965eeb7
delete NettyAdaptiveCumulator
shivaspeaks Oct 8, 2026
99c0265
make fields private
shivaspeaks Oct 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions netty/src/main/java/io/grpc/netty/GrpcHttp2ConnectionHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@
import io.grpc.Internal;
import io.grpc.InternalChannelz;
import io.netty.channel.ChannelPromise;
import io.netty.handler.codec.AdaptiveCumulator;
import io.netty.handler.codec.ByteToMessageDecoder.Cumulator;
import io.netty.handler.codec.http2.Http2ConnectionDecoder;
import io.netty.handler.codec.http2.Http2ConnectionEncoder;
import io.netty.handler.codec.http2.Http2ConnectionHandler;
Expand All @@ -34,6 +36,10 @@
*/
@Internal
public abstract class GrpcHttp2ConnectionHandler extends Http2ConnectionHandler {
private static final int ADAPTIVE_CUMULATOR_COMPOSE_MIN_SIZE_DEFAULT = 1024;
private static final Cumulator ADAPTIVE_CUMULATOR =
new AdaptiveCumulator(ADAPTIVE_CUMULATOR_COMPOSE_MIN_SIZE_DEFAULT);

@Nullable
protected final ChannelPromise channelUnused;
private final ChannelLogger negotiationLogger;
Expand All @@ -48,6 +54,7 @@ protected GrpcHttp2ConnectionHandler(
super(decoder, encoder, initialSettings);
this.channelUnused = channelUnused;
this.negotiationLogger = negotiationLogger;
setCumulator(ADAPTIVE_CUMULATOR);
}

/**
Expand Down
228 changes: 0 additions & 228 deletions netty/src/main/java/io/grpc/netty/NettyAdaptiveCumulator.java
View file
Open in desktop

This file was deleted.

Loading
Loading