Repository navigation
Revert "core: Delayed deserialization for unary/server-streaming calls (#13004) - #13107
Merged
kannanjgithub merged 1 commit intoOct 9, 2026
Conversation
grpc#13004)" This reverts commit 8ba4b48.
shivaspeaks
approved these changes
Oct 9, 2026
kannanjgithub
added a commit
that referenced
this pull request
Oct 12, 2026
#13004) (v1.84.x backport) (#13110) Backport of #13107 to v1.84.x. --- This reverts commit 8ba4b48 because this change breaks grpc-kotlin tests that use InProcessTransport by causing a deadlock because [ServerCalls.kt](https://github.com/grpc/grpc-kotlin/blob/master/stub/src/main/java/io/grpc/kotlin/ServerCalls.kt#L214-L215) only requests the next message after `onMessage` delivers the current one, and messages get queued because the client hasn't called `halfClose` yet. When the client halfCloses, `InProcessTransport.halfClose` [defers](https://github.com/grpc/grpc-java/blob/master/inprocess/src/main/java/io/grpc/inprocess/InProcessTransport.java#L904) delivering halfClose if the server's receive queue is non-empty. **Resulting Deadlock:** - `ServerCallImpl` waits for `halfClosed()` before dispatching Message 1. - `InProcessTransport` waits for `call.request(1)` before dispatching `halfClosed()`. - The server waits for Message 1 before calling `call.request(1)`. - The test hangs indefinitely waiting for `closeStatus.await()` until the 10s test timeout expires. There are a few other failures too but those can be fixed in the test code alone. Internal Test failures: http://shortn/_If0NinnwQ4
kannanjgithub
added a commit
that referenced
this pull request
Oct 13, 2026
Restore delayed deserialization and lazy decompression for unary and server-streaming calls (originally introduced in #13004 and reverted in #13107). Additionally, convert ServerCall.request(1) to stream.request(2) for unary and server-streaming calls (clientSendsOneMessage()) to prevent transport deadlocks if multiple messages arrive on the stream.
kannanjgithub
added a commit
that referenced
this pull request
Oct 19, 2026
….x backport) (#13132) Backport of #13113 to v1.85.x. --- Restore delayed deserialization and lazy decompression for unary and server-streaming calls (originally introduced in #13004 and reverted in #13107). Additionally, convert ServerCall.request(1) to stream.request(2) for unary and server-streaming calls (clientSendsOneMessage()) to prevent transport deadlocks if multiple messages arrive on the stream.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 8ba4b48 because this change breaks grpc-kotlin tests that use InProcessTransport by causing a deadlock because ServerCalls.kt only requests the next message after
onMessagedelivers the current one, and messages get queued because the client hasn't calledhalfCloseyet. When the client halfCloses,InProcessTransport.halfClosedefers delivering halfClose if the server's receive queue is non-empty.Resulting Deadlock:
ServerCallImplwaits forhalfClosed()before dispatching Message 1.InProcessTransportwaits forcall.request(1)before dispatchinghalfClosed().call.request(1).closeStatus.await()until the 10s test timeout expires.There are a few other failures too but those can be fixed in the test code alone.
Internal Test failures: http://shortn/_If0NinnwQ4