From 20f92cf8f1c6b4ef5b6dafe3fc4fd79cdbd22b39 Mon Sep 17 00:00:00 2001 From: jdcormie Date: Wed, 28 Oct 2026 10:18:18 -0700 Subject: [PATCH] bazel: Upgrade rules_java to 9.1.0 in WORKSPACE to support JDK 25 The WORKSPACE build pinned rules_java 8.15.2, whose newest bundled JDK is 21. Bazel's default --java_runtime_version is local_jdk, so on a host whose default JDK is newer than 21 the javac toolchain cannot target it and the build fails: error: [BazelJavaConfiguration] The Java 21 runtime used to run javac is not recent enough to compile for the Java 25 runtime in external/local_jdk. This started failing in CI when GitHub's ubuntu-latest runner image moved from Ubuntu 24.04 (default JDK 17) to 26.04 (default JDK 25). The bzlmod build was unaffected because MODULE.bazel already uses rules_java 9.1.0. Upgrade the WORKSPACE build to the same rules_java 9.1.0. Since 8.16, rules_java_deps.bzl loads @bazel_features, so bazel_features_deps() must now run before rules_java_dependencies(). examples/ has its own WORKSPACE, so apply the same change there. --- WORKSPACE | 12 ++++++------ examples/WORKSPACE | 12 ++++++------ 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/WORKSPACE b/WORKSPACE index 1efdf2793a8..a2165730c36 100644 --- a/WORKSPACE +++ b/WORKSPACE @@ -7,9 +7,9 @@ grpc_java_repositories() http_archive( name = "rules_java", - sha256 = "47632cc506c858011853073449801d648e10483d4b50e080ec2549a4b2398960", + sha256 = "4e1a28a25c2efa53500c928d22ceffbc505dd95b335a2d025836a293b592212f", urls = [ - "https://github.com/bazelbuild/rules_java/releases/download/8.15.2/rules_java-8.15.2.tar.gz", + "https://github.com/bazelbuild/rules_java/releases/download/9.1.0/rules_java-9.1.0.tar.gz", ], ) @@ -17,14 +17,14 @@ load("@com_google_protobuf//:protobuf_deps.bzl", "PROTOBUF_MAVEN_ARTIFACTS", "pr protobuf_deps() -load("@rules_java//java:rules_java_deps.bzl", "rules_java_dependencies") - -rules_java_dependencies() - load("@bazel_features//:deps.bzl", "bazel_features_deps") bazel_features_deps() +load("@rules_java//java:rules_java_deps.bzl", "rules_java_dependencies") + +rules_java_dependencies() + load("@bazel_jar_jar//:jar_jar.bzl", "jar_jar_repositories") jar_jar_repositories() diff --git a/examples/WORKSPACE b/examples/WORKSPACE index 1387cc4cf12..ac156be8d76 100644 --- a/examples/WORKSPACE +++ b/examples/WORKSPACE @@ -20,9 +20,9 @@ grpc_java_repositories() http_archive( name = "rules_java", - sha256 = "47632cc506c858011853073449801d648e10483d4b50e080ec2549a4b2398960", + sha256 = "4e1a28a25c2efa53500c928d22ceffbc505dd95b335a2d025836a293b592212f", urls = [ - "https://github.com/bazelbuild/rules_java/releases/download/8.15.2/rules_java-8.15.2.tar.gz", + "https://github.com/bazelbuild/rules_java/releases/download/9.1.0/rules_java-9.1.0.tar.gz", ], ) @@ -32,14 +32,14 @@ load("@com_google_protobuf//:protobuf_deps.bzl", "PROTOBUF_MAVEN_ARTIFACTS", "pr protobuf_deps() -load("@rules_java//java:rules_java_deps.bzl", "compatibility_proxy_repo", "rules_java_dependencies") - -rules_java_dependencies() - load("@bazel_features//:deps.bzl", "bazel_features_deps") bazel_features_deps() +load("@rules_java//java:rules_java_deps.bzl", "compatibility_proxy_repo", "rules_java_dependencies") + +rules_java_dependencies() + compatibility_proxy_repo() load("@bazel_jar_jar//:jar_jar.bzl", "jar_jar_repositories")