Skip to content

Fall back to fast after 2s - #77

Open
SrinivasVagvala wants to merge 1 commit into
mainfrom
srinivas/label-reader-async
Open

SrinivasVagvala wants to merge 1 commit into
mainfrom
srinivas/label-reader-async

Conversation

@SrinivasVagvala

Copy link
Copy Markdown
Collaborator

I changed the code to allow it to fall back to .fast after 2 second using the new function. I also used the centres of the word to handle 2 line labels and read them out correctly. I also updated the tests that can test these changes.

What changed

Which package

  • Packages/ContourCore — the contract (see the warning below)
  • Packages/SurfaceUnderstanding — Surface Understanding
  • Packages/Tracking — Tracking / Spatial
  • Packages/ContourFeedback — Experience
  • Packages/ContourUI — Experience
  • Packages/ContourMocks — shared fakes (Experience)
  • ContourApp — app target / wiring
  • Harness — macOS test rig (Experience)
  • Repo plumbing (CI, docs, scripts)

Which lane

How it was tested

Does this touch ContourCore?

  • No — merge when one reviewer from my team approves.
  • Yes — this changes the shared contract.

If you ticked yes

ContourCore is frozen from the end of Week 2. Changing it breaks all three
teams at once, so it needs the leads of all three teams to approve —
Surface Understanding, Tracking / Spatial, and Experience. Not one team, not a
majority.

  • Tagged the leads of all three teams on this PR
  • Said below what breaks and who has to change code
  • Updated COORDINATES.md if this touches the coordinate convention
  • Updated ContourMocks so the fakes still match the contract

What breaks and who has to change code:

Screenshots / recordings

I changed the code to allow it to fall back to .fast after 2 second using the new function. I also used the centres of the word to handle 2 line labels and read them out correctly. I also updated the tests that can test these changes.
@SrinivasVagvala SrinivasVagvala linked an issue Oct 12, 2026 that may be closed by this pull request
7 of 9 tasks
@SrinivasVagvala

Copy link
Copy Markdown
Collaborator Author

MY BRANCH_______________________
PHOTO RUN: 30 photos, "start" on 18, 0.62 s per photo on average, slowest 1.39 s
✔ Test "photo run" passed after 40.826 seconds.
✔ Test run with 1 test in 0 suites passed after 40.828 seconds.
MAIN______
PHOTO RUN: 30 photos, "start" on 18, 0.58 s per photo on average, slowest 1.43 s
✔ Test "photo run" passed after 36.938 seconds.
✔ Test run with 1 test in 0 suites passed after 36.939 seconds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Labels] Fall back to .fast after 2 s, and fix two-line label order

2 participants