chore(openapi): [main] update client/openapi/trustd.yaml - #1213
Open
trustify-ci-bot[bot] wants to merge 1 commit into
Open
chore(openapi): [main] update client/openapi/trustd.yaml#1213trustify-ci-bot[bot] wants to merge 1 commit into
trustify-ci-bot[bot] wants to merge 1 commit into
Conversation
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Contributor
Reviewer's GuideUpdates the trustd OpenAPI specification to version 0.6.0-rc.1 by adding exploit/KEV-related APIs, schemas, and importer configuration, and wiring exploit data into existing vulnerability responses and catalog source enums. Sequence diagram for exploit listing and retrieval APIssequenceDiagram
actor Client
participant trustd
Client->>trustd: listExploits(q, sort, offset, limit, total)
trustd-->>Client: PaginatedResults_Exploit
Client->>trustd: getExploit(id)
trustd-->>Client: Exploit
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The
PaginatedResults_Exploit.itemsschema duplicates theExploitschema instead of referencing it; consider reusing#/components/schemas/Exploitto avoid divergence between the two definitions. - The new
cisakevcatalog identifier and thesourceexample value "cisa-kev" use slightly different naming; consider standardizing these identifiers to a single canonical form to avoid confusion in clients.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `PaginatedResults_Exploit.items` schema duplicates the `Exploit` schema instead of referencing it; consider reusing `#/components/schemas/Exploit` to avoid divergence between the two definitions.
- The new `cisakev` catalog identifier and the `source` example value "cisa-kev" use slightly different naming; consider standardizing these identifiers to a single canonical form to avoid confusion in clients.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1213 +/- ##
==========================================
+ Coverage 54.19% 54.20% +0.01%
==========================================
Files 255 255
Lines 5715 5715
Branches 1774 1774
==========================================
+ Hits 3097 3098 +1
Misses 2355 2355
+ Partials 263 262 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The openapi.yaml of trustify has changed
Summary by Sourcery
Update the Trustify OpenAPI specification to support CISA KEV exploit data and expose exploit reporting endpoints and schemas.
New Features:
Enhancements: