Skip to content

Commit 11b4ea4

Browse files
committed
Reserve 90px ad space for top-above-nav on tablet
1 parent 3136839 commit 11b4ea4

1 file changed

Lines changed: 14 additions & 3 deletions

File tree

dotcom-rendering/src/components/AdSlot.web.tsx

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ const hideBelowDesktop = css`
108108
}
109109
`;
110110

111-
const containerMinHeight = getMinHeightOfAdSlot(250, space[5]);
111+
const topAboveNavPaddingHeight = space[5];
112112

113113
const topAboveNavContainerStyles = css`
114114
padding-bottom: ${space[5]}px;
@@ -117,7 +117,17 @@ const topAboveNavContainerStyles = css`
117117
text-align: left;
118118
display: block;
119119
width: 100%;
120-
min-height: ${containerMinHeight}px;
120+
121+
min-height: ${getMinHeightOfAdSlot(
122+
adSizes.leaderboard.height,
123+
topAboveNavPaddingHeight,
124+
)}px;
125+
${from.desktop} {
126+
min-height: ${getMinHeightOfAdSlot(
127+
adSizes.billboard.height,
128+
topAboveNavPaddingHeight,
129+
)}px;
130+
}
121131
122132
/* Remove the min-height when the ad has rendered, so that the container can shrink if the ad is smaller */
123133
&[top-above-nav-ad-rendered='true'] {
@@ -129,7 +139,7 @@ const topAboveNavContainerStyles = css`
129139
::before {
130140
content: '';
131141
position: absolute;
132-
height: ${adSizes.billboard.height}px;
142+
height: ${adSizes.leaderboard.height}px;
133143
width: ${adSizes.leaderboard.width}px;
134144
top: ${labelHeight}px;
135145
left: 50%;
@@ -138,6 +148,7 @@ const topAboveNavContainerStyles = css`
138148
}
139149
${from.desktop} {
140150
::before {
151+
height: ${adSizes.billboard.height}px;
141152
width: ${adSizes.billboard.width}px;
142153
}
143154
}

0 commit comments

Comments
 (0)