Rename EditorialTest to FrontEditorialTest

Author: emma-imber

dotcom-rendering/src/frontend/feFront.ts

@@ -9,7 +9,7 @@ import type {
 	StarRating,
 } from '../types/content';
 import type { FooterType } from '../types/footer';
-import type { EditorialTest } from '../types/front';
+import type { FrontEditorialTest } from '../types/front';
 import type { FENavType } from '../types/frontend';
 import type { FETagType } from '../types/tag';
 import type { Territory } from '../types/territory';
@@ -206,7 +206,7 @@ export type FEFrontCard = {
 		href?: string;
 		embedUri?: string;
 		newsletterData?: Newsletter;
-		tests?: EditorialTest[];
+		tests?: FrontEditorialTest[];
 	};
 	header: {
 		isVideo: boolean;
@@ -434,7 +434,7 @@ export type FESupportingContent = {
 	properties: {
 		href?: string;
 		webUrl?: string;
-		tests?: EditorialTest[];
+		tests?: FrontEditorialTest[];
 	};
 	header: {
 		kicker?: {

dotcom-rendering/src/model/enhanceCards.test.ts

@@ -5,7 +5,7 @@ import type {
 	FESupportingContent,
 } from '../frontend/feFront';
 import { ArticleDesign, ArticleDisplay, Pillar } from '../lib/articleFormat';
-import type { EditorialTest, VariantMeta } from '../types/front';
+import type { FrontEditorialTest, VariantMeta } from '../types/front';
 import type { MainMedia } from '../types/mainMedia';
 import {
 	decideArticleMedia,
@@ -626,7 +626,7 @@ describe('Enhance Cards', () => {
 								},
 							} as VariantMeta,
 						],
-					} as EditorialTest,
+					} as FrontEditorialTest,
 				],
 			},
 		};
@@ -639,7 +639,7 @@ describe('Enhance Cards', () => {
 					{
 						...cardWithEditorialTest.properties.tests[0],
 						expiryDate: Date.now() - oneHourInMilliseconds,
-					} as EditorialTest,
+					} as FrontEditorialTest,
 				],
 			},
 		};
@@ -652,7 +652,7 @@ describe('Enhance Cards', () => {
 					{
 						...cardWithEditorialTest.properties.tests[0],
 						hasManuallyEndedOnThisTrail: true,
-					} as EditorialTest,
+					} as FrontEditorialTest,
 				],
 			},
 		};

dotcom-rendering/src/model/enhanceCards.ts

@@ -26,7 +26,7 @@ import type {
 	DCRFrontCard,
 	DCRSlideshowImage,
 	DCRSupportingContent,
-	EditorialTest,
+	FrontEditorialTest,
 } from '../types/front';
 import type { ArticleMedia, MainMedia } from '../types/mainMedia';
 import type { PodcastSeriesImage, TagType } from '../types/tag';
@@ -203,7 +203,7 @@ const decideVideoAtomImage = (
  * Checks if an editorial test is active by making sure it has not been manually ended,
  * that it has a valid expiry date, and that the expiry date is in the future
  */
-const isActiveEditorialTest = (test: EditorialTest) =>
+const isActiveEditorialTest = (test: FrontEditorialTest) =>
 	!test.hasManuallyEndedOnThisTrail &&
 	!!test.expiryDate &&
 	test.expiryDate > Date.now();
@@ -213,8 +213,8 @@ const isActiveEditorialTest = (test: EditorialTest) =>
  * test is found, return undefined
  */
 const findActiveEditorialTest = (
-	tests: EditorialTest[] | undefined,
-): EditorialTest | undefined => {
+	tests: FrontEditorialTest[] | undefined,
+): FrontEditorialTest | undefined => {
 	return tests?.find((test) => isActiveEditorialTest(test));
 };
 

dotcom-rendering/src/types/front.ts

@@ -182,7 +182,7 @@ export type VariantMeta = {
 	};
 };
 
-export type EditorialTest = {
+export type FrontEditorialTest = {
 	testUuid: string;
 	variantMeta: VariantMeta[];
 	startDate?: number;